-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
doc: add missing environment variables to manpage #58963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c7650c6
to
bd66732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @HumaneLogic 🙂
Sorry Just a few last adjustments and I think this should be ready 🙂
@HumaneLogic could you please update the commit message to be |
@dario-piotrowicz omg you're back, hi nice to meet you, yes, i'm on it |
677c488
to
8e0c011
Compare
@dario-piotrowicz i accidentally closed the pull request sorry, i reopened it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58963 +/- ##
=======================================
Coverage 90.07% 90.07%
=======================================
Files 641 641
Lines 188594 188594
Branches 36998 36997 -1
=======================================
+ Hits 169869 169883 +14
+ Misses 11438 11437 -1
+ Partials 7287 7274 -13 🚀 New features to boost your workflow:
|
8e0c011
to
3ab096d
Compare
3ab096d
to
68e7202
Compare
@dario-piotrowicz it's ok bro i fixed it the reason that it took me so long to fix it, is because i only knew git add . git commit -m "" and git push before this PR, now i know maybe 30 commands more or less |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @HumaneLogic 🙂
Description:
Adds missing environment variables to manpage:
NODE_COMPILE_CACHE
NODE_DISABLE_COMPILE_CACHE
NODE_PENDING_PIPE_INSTANCES
NODE_TEST_CONTEXT
NODE_USE_ENV_PROXY
Reference:
Fixes: #58894