Skip to content

doc: add missing environment variables to manpage #58963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

doc: add missing environment variables to manpage #58963

merged 1 commit into from
Jul 11, 2025

Conversation

HumaneLogic
Copy link
Contributor

@HumaneLogic HumaneLogic commented Jul 5, 2025 •
edited
Loading

Description:
Adds missing environment variables to manpage:

  • NODE_COMPILE_CACHE
  • NODE_DISABLE_COMPILE_CACHE
  • NODE_PENDING_PIPE_INSTANCES
  • NODE_TEST_CONTEXT
  • NODE_USE_ENV_PROXY

Reference:
Fixes: #58894

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 5, 2025
@HumaneLogic HumaneLogic mentioned this pull request Jul 5, 2025
Closed
@HumaneLogic HumaneLogic force-pushed the clean-manpage-fixes branch from c7650c6 to bd66732 Compare July 5, 2025 15:43
dario-piotrowicz
dario-piotrowicz reviewed Jul 5, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @HumaneLogic 🙂

Sorry Just a few last adjustments and I think this should be ready 🙂

@dario-piotrowicz
Copy link
Member

@HumaneLogic could you please update the commit message to be doc: add missing environment variables to manpage ?

@HumaneLogic
Copy link
Contributor Author

@dario-piotrowicz omg you're back, hi nice to meet you, yes, i'm on it

@HumaneLogic HumaneLogic force-pushed the clean-manpage-fixes branch from 677c488 to 8e0c011 Compare July 6, 2025 07:42
@HumaneLogic HumaneLogic closed this Jul 6, 2025
@HumaneLogic HumaneLogic reopened this Jul 6, 2025
@HumaneLogic
Copy link
Contributor Author

@dario-piotrowicz i accidentally closed the pull request sorry, i reopened it

@dario-piotrowicz dario-piotrowicz changed the title doc: add missing env vars and remove test fallback doc: add missing environment variables to manpage Jul 6, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (9c025a9) to head (68e7202).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58963   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files         641      641           
  Lines      188594   188594           
  Branches    36998    36997    -1     
=======================================
+ Hits       169869   169883   +14     
+ Misses      11438    11437    -1     
+ Partials     7287     7274   -13

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dario-piotrowicz
dario-piotrowicz reviewed Jul 6, 2025
View reviewed changes
@HumaneLogic HumaneLogic force-pushed the clean-manpage-fixes branch from 8e0c011 to 3ab096d Compare July 7, 2025 16:08
@HumaneLogic HumaneLogic force-pushed the clean-manpage-fixes branch from 3ab096d to 68e7202 Compare July 7, 2025 20:46
@HumaneLogic
Copy link
Contributor Author

@dario-piotrowicz it's ok bro i fixed it

the reason that it took me so long to fix it, is because i only knew git add . git commit -m "" and git push before this PR, now i know maybe 30 commands more or less
i had problem with squashing , now i feel confident , i love it if i can fix something in this project, i feel really good, thanks bro

dario-piotrowicz
dario-piotrowicz approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @HumaneLogic 🙂

@dario-piotrowicz dario-piotrowicz added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67897/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 0d128e3 into nodejs:main Jul 11, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0d128e3

targos pushed a commit that referenced this pull request Jul 17, 2025
@HumaneLogic @targos
doc: add missing environment variables to manpage
9d02960 
PR-URL: #58963
Fixes: #58894
Reviewed-By: Dario Piotrowicz <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some environment variables documented in the CLI docs are missing in node manpage
5 participants
@HumaneLogic @dario-piotrowicz @nodejs-github-bot @lpinca @aduh95