Skip to content

[v20.x backport] crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 #58961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v20.x-staging
Choose a base branch
from
Open

[v20.x backport] crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 #58961

wants to merge 2 commits into from
+116 −24

Conversation

panva
Copy link
Member

@panva panva commented Jul 5, 2025

Backports #58942 to v20.x

aduh95 and others added 2 commits June 23, 2025 12:20
@aduh95
tools: disable failing coverage jobs
1b8f5da 
PR-URL: nodejs#58770
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@panva
crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
ca8d3a7 
Reverts: nodejs#56160
Fixes: nodejs#56159
Fixes: nodejs#58913
Refs: nodejs#58121
PR-URL: nodejs#58942
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jul 5, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67849/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67850/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67852/

Hardanish-Singh
Hardanish-Singh reviewed Jul 5, 2025
View reviewed changes
Copy link

@Hardanish-Singh Hardanish-Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardanish-Singh Hardanish-Singh Hardanish-Singh left review comments

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @Hardanish-Singh @aduh95