-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
[v22.x backport] crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 #58960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panva
wants to merge
17
commits into
nodejs:v22.x-staging
Choose a base branch
from
panva:backport-58942-to-22
base: v22.x-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#58610 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
Port 9229 may already be used by another process. Use a random available one. PR-URL: nodejs#58799 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
Allow the test to be run in parallel. Refs: nodejs#58799 (comment) PR-URL: nodejs#58799 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
PR-URL: nodejs#58914 Reviewed-By: Richard Lau <[email protected]>
Fixes: nodejs#58801 PR-URL: nodejs#58902 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#56350 Backport-PR-URL: nodejs#57298 Fixes: nodejs/typescript#17 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>
PR-URL: nodejs#58175 Backport-PR-URL: nodejs#57298 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
This commit refactors the CommonJS loader to remove TypeScript-specific extensions from the require.extensions object for compatibility with libraries that depended on it to initialize extenal TypeScript loaders. PR-URL: nodejs#58657 Backport-PR-URL: nodejs#57298 Refs: nodejs/typescript#37 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#58643 Backport-PR-URL: nodejs#57298 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#57687 Backport-PR-URL: nodejs#57298 Fixes: nodejs#56830 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#57687 Backport-PR-URL: nodejs#57298 Fixes: nodejs#56830 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#57704 Backport-PR-URL: nodejs#57298 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#57871 Backport-PR-URL: nodejs#57298 Fixes: nodejs#57471 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#58174 Backport-PR-URL: nodejs#57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jacob Smith <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#58639 Backport-PR-URL: nodejs#57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
PR-URL: nodejs#58754 Backport-PR-URL: nodejs#57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> PR-URL: nodejs#56350 Fixes: nodejs/typescript#17
Review requested:
|
Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121 PR-URL: nodejs#58942 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
64d16c4
to
76ca72e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
v22.x
Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #58942 to v22.x