Skip to content

[v22.x backport] crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 #58960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: v22.x-staging
Choose a base branch
from

Conversation

panva
Copy link
Member

@panva panva commented Jul 5, 2025

Backports #58942 to v22.x

LiviaMedeiros and others added 16 commits July 3, 2025 11:51
PR-URL: nodejs#58610
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Port 9229 may already be used by another process. Use a random
available one.

PR-URL: nodejs#58799
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Allow the test to be run in parallel.

Refs: nodejs#58799 (comment)
PR-URL: nodejs#58799
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Fixes: nodejs#58801
PR-URL: nodejs#58902
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#56350
Backport-PR-URL: nodejs#57298
Fixes: nodejs/typescript#17
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
PR-URL: nodejs#58175
Backport-PR-URL: nodejs#57298
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
This commit refactors the CommonJS loader to remove TypeScript-specific
extensions from the require.extensions object for compatibility with
libraries that depended on it to initialize extenal TypeScript loaders.

PR-URL: nodejs#58657
Backport-PR-URL: nodejs#57298
Refs: nodejs/typescript#37
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#58643
Backport-PR-URL: nodejs#57298
Refs: nodejs/typescript#24
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#57687
Backport-PR-URL: nodejs#57298
Fixes: nodejs#56830
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#57687
Backport-PR-URL: nodejs#57298
Fixes: nodejs#56830
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#57704
Backport-PR-URL: nodejs#57298
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#57871
Backport-PR-URL: nodejs#57298
Fixes: nodejs#57471
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#58174
Backport-PR-URL: nodejs#57298
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#58639
Backport-PR-URL: nodejs#57298
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
PR-URL: nodejs#58754
Backport-PR-URL: nodejs#57298
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: nodejs#56350
Fixes: nodejs/typescript#17
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jul 5, 2025
Reverts: nodejs#56160
Fixes: nodejs#56159
Fixes: nodejs#58913
Refs: nodejs#58121
PR-URL: nodejs#58942
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@panva panva force-pushed the backport-58942-to-22 branch from 64d16c4 to 76ca72e Compare July 5, 2025 11:57
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67856/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants