repl: catch promise errors during eval in completion #58943

islandryu · 2025-07-03T14:20:11Z

Fixes: #58903
The issue occurred when an unhandled Promise was executed during the completion's eval.

This change catches and ignores the error, similar to the handling here.

node/lib/repl.js

Line 1544 in 6a3b545

const evalExpr = `try { ${expr} } catch {}`;

codecov · 2025-07-03T16:52:37Z

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.04%. Comparing base (09b4c57) to head (7b2d30c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/repl.js	66.66%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58943      +/-   ##
==========================================
- Coverage   90.07%   90.04%   -0.04%     
==========================================
  Files         641      641              
  Lines      188998   189007       +9     
  Branches    37069    37079      +10     
==========================================
- Hits       170246   170192      -54     
- Misses      11462    11515      +53     
- Partials     7290     7300      +10

Files with missing lines	Coverage Δ
lib/repl.js	`94.09% <66.66%> (-0.12%)`	⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dario-piotrowicz

The fix itself looks good to me, however I feel like the tests could be improved

dario-piotrowicz · 2025-07-05T13:03:56Z

test/parallel/test-repl-eval-promises.js

+  { send: `async function f() {}; f().` },
+];
+
+const tests = [


Why are there non-completion tests here?

If these tests are necessary I would suggest to have them in their own separate test file, I don't think there's any benefit in running both set of tests here, is there?

I had originally added it just to be safe, even though I knew it wouldn't have any real effect.
But since it’s not strictly necessary, I’ve removed it.

I think we can add it as a separate test file, as I had a quick look and I feel like promise evaluation is not being tested? anyways that can be also done separately if we want I think 🙂

Oh I see, I'll keep it as well in a separate file.
Is it okay to include that in this PR?

Oh I see, I'll keep it as well in a separate file.

yeah sounds good to me 🙂

Is it okay to include that in this PR?

Of course 🙂

If you're up for it I think it would be great if you could rebase and have two commits here, one for the tab-complete and one for the new eval tests then we can commit-queue-rebase and have the two clean commits in, I think that that would be the cleanest way to land this 🙂 , but if you don't feel like it the current merge squash is completely fine too 👍

I’ve rebased the branch!

dario-piotrowicz · 2025-07-05T13:14:03Z

test/parallel/test-repl-eval-promises.js

+  await runReplTests(tests);
+})().then(common.mustCall());
+
+async function runReplCompleteTests(tests) {


In my opinion tab completion tests should use the repl's complete function as I think that it is the cleanest most robust/stable way for testing this functionality (no need to collect the repl output and add setTimeouts).

For example you can see here: https://github.com/dario-piotrowicz/node/blob/34f24960fb813609f3bd0080ac26bbee1611f142/test/parallel/test-repl-tab-complete-computed-props.js how I recently did it

You can also notice in my tests that the strategy allows to use a single repl instance (since anyways the tests don't rely on state) instead of creating a new one every time

Thanks, Your approach definitely makes things much simpler.
I've updated the tests to use repl.complete, and also renamed the file accordingly to reflect the change.

dario-piotrowicz

Looks great, thanks for the updates @islandryu 🫶

nodejs-github-bot · 2025-07-09T08:22:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67900/

Fixes: nodejs#58903

islandryu · 2025-07-10T12:23:21Z

@dario-piotrowicz
Could you take another look? I’ve updated the commit.
I only resolved conflicts with the main branch.

nodejs-github-bot · 2025-07-10T12:28:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67924/

dario-piotrowicz

@dario-piotrowicz Could you take another look? I’ve updated the commit. I only resolved conflicts with the main branch.

Hi @islandryu 👋

Sorry about the merge conflicts those were my fault 🙇

The changes still look good to me 😄

However now there's an extra eval that I think should also include your check:

node/lib/repl.js

Line 1822 in 7b2d30c

`try { ${exprStr} } catch {} `, ctx, getREPLResourceName(), (err, obj) => {

If you could also add the check there (alongside a test if it's not too problematic) that'd be great 😄

But if you want I can also do that in a separate PR, up to you 🙂

islandryu · 2025-07-10T14:44:15Z

Thanks for pointing that out!
I'll go ahead and add the check and a test for that part as well.
I’ll probably be able to take a look over the weekend

islandryu · 2025-07-13T14:52:51Z

#59044
There is a conflict, so I will address it after finishing this fix.

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jul 3, 2025

dario-piotrowicz reviewed Jul 5, 2025

View reviewed changes

islandryu force-pushed the 58903 branch from 3fa4356 to e11cad6 Compare July 8, 2025 13:17

dario-piotrowicz approved these changes Jul 8, 2025

View reviewed changes

dario-piotrowicz added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 8, 2025

jasnell approved these changes Jul 8, 2025

View reviewed changes

dario-piotrowicz approved these changes Jul 8, 2025

View reviewed changes

islandryu force-pushed the 58903 branch from b403c3e to f1f0185 Compare July 9, 2025 01:13

islandryu added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 9, 2025

islandryu added 2 commits July 10, 2025 17:40

repl: catch promise errors during eval in completion

c9cd561

Fixes: nodejs#58903

test: add repl test for promise eval

7b2d30c

islandryu force-pushed the 58903 branch from f1f0185 to 7b2d30c Compare July 10, 2025 09:37

islandryu requested a review from dario-piotrowicz July 10, 2025 12:22

dario-piotrowicz approved these changes Jul 10, 2025

View reviewed changes

islandryu mentioned this pull request Jul 13, 2025

repl: handle errors from getters during completion #59044

Open

Uh oh!

repl: catch promise errors during eval in completion #58943

Are you sure you want to change the base?

repl: catch promise errors during eval in completion #58943

Conversation

islandryu commented Jul 3, 2025

Uh oh!

codecov bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

islandryu Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

islandryu Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

islandryu Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

islandryu Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 9, 2025

Uh oh!

islandryu commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 10, 2025

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

islandryu commented Jul 10, 2025

Uh oh!

islandryu commented Jul 13, 2025

Uh oh!

Uh oh!

codecov bot commented Jul 3, 2025 •

edited

Loading

dario-piotrowicz Jul 5, 2025 •

edited

Loading

dario-piotrowicz Jul 5, 2025 •

edited

Loading

islandryu Jul 8, 2025 •

edited

Loading

islandryu commented Jul 10, 2025 •

edited

Loading