-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
meta: enable eslint jsdoc rules #58521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anonrig
wants to merge
10
commits into
nodejs:main
Choose a base branch
from
anonrig:yagiz/enable-eslint-jsdoc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+495
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
273c1fb
to
1706d82
Compare
jasnell
approved these changes
May 31, 2025
cb6ed80
to
4165c4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58521 +/- ##
========================================
Coverage 90.06% 90.07%
========================================
Files 645 645
Lines 189130 189330 +200
Branches 37094 37093 -1
========================================
+ Hits 170339 170530 +191
+ Misses 11511 11507 -4
- Partials 7280 7293 +13
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
bjohansebas
approved these changes
May 31, 2025
LiviaMedeiros
approved these changes
Jun 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
cc @LiviaMedeiros @jasnell can you re-review? |
LiviaMedeiros
approved these changes
Jun 1, 2025
aduh95
reviewed
Jun 2, 2025
aduh95
reviewed
Jun 2, 2025
aduh95
reviewed
Jun 2, 2025
aduh95
reviewed
Jun 2, 2025
aduh95
reviewed
Jun 2, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
9dbe731
to
0813c52
Compare
targos
approved these changes
Jul 15, 2025
Commit Queue failed- Loading data for nodejs/node/pull/58521 ✔ Done loading data for nodejs/node/pull/58521 ----------------------------------- PR info ------------------------------------ Title meta: enable eslint jsdoc rules (#58521) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anonrig:yagiz/enable-eslint-jsdoc -> nodejs:main Labels tools, author ready, commit-queue-squash Commits 10 - meta: enable jsdoc/check-tag-names rule - meta: enable jsdoc/no-defaults rule - meta: enable jsdoc/valid-types rule - meta: enable jsdoc/require-returns rule - fixup! meta: enable jsdoc/check-tag-names rule - meta: enable jsdoc/check-line-alignment rule - meta: enable jsdoc/check-alignment rule - Update source_map.js - Update eslint.config.mjs - fix eslint errors Committers 1 - Yagiz Nizipli <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58521 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58521 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 31 May 2025 00:31:26 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58521#pullrequestreview-2882947324 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/58521#pullrequestreview-2885824763 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/58521#pullrequestreview-3018831710 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-01T16:43:29Z: https://ci.nodejs.org/job/node-test-pull-request/67232/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - meta: enable jsdoc/check-tag-names rule ⚠ - meta: enable jsdoc/no-defaults rule ⚠ - meta: enable jsdoc/valid-types rule ⚠ - meta: enable jsdoc/require-returns rule ⚠ - fixup! meta: enable jsdoc/check-tag-names rule ⚠ - meta: enable jsdoc/check-line-alignment rule ⚠ - meta: enable jsdoc/check-alignment rule ⚠ - Update source_map.js ⚠ - Update eslint.config.mjs ⚠ - fix eslint errors - Querying data for job/node-test-pull-request/67232/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16293920493 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose enabling jsdoc eslint rules. This would help a lot for maintainance, and help create a more consistent code base. Currently, we have jsdoc in some areas but not in all places. Additionally, this would help folks maintaining
@types/node
package a lot.