Skip to content

meta: enable eslint jsdoc rules #58521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 31, 2025

I propose enabling jsdoc eslint rules. This would help a lot for maintainance, and help create a more consistent code base. Currently, we have jsdoc in some areas but not in all places. Additionally, this would help folks maintaining @types/node package a lot.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 31, 2025
@anonrig anonrig force-pushed the yagiz/enable-eslint-jsdoc branch from 273c1fb to 1706d82 Compare May 31, 2025 00:31
@anonrig anonrig force-pushed the yagiz/enable-eslint-jsdoc branch 5 times, most recently from cb6ed80 to 4165c4f Compare May 31, 2025 15:47
@anonrig anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 31, 2025
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (049664b) to head (0813c52).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #58521    +/-   ##
========================================
  Coverage   90.06%   90.07%            
========================================
  Files         645      645            
  Lines      189130   189330   +200     
  Branches    37094    37093     -1     
========================================
+ Hits       170339   170530   +191     
+ Misses      11511    11507     -4     
- Partials     7280     7293    +13     
Files with missing lines Coverage Δ
lib/_http_common.js 100.00% <100.00%> (ø)
lib/buffer.js 100.00% <100.00%> (ø)
lib/events.js 99.58% <100.00%> (+<0.01%) ⬆️
lib/https.js 99.30% <100.00%> (ø)
lib/internal/abort_controller.js 98.27% <100.00%> (+<0.01%) ⬆️
lib/internal/async_hooks.js 99.36% <100.00%> (ø)
lib/internal/blob.js 99.80% <100.00%> (ø)
lib/internal/crypto/hash.js 98.89% <100.00%> (+<0.01%) ⬆️
lib/internal/crypto/random.js 96.09% <100.00%> (ø)
lib/internal/data_url.js 100.00% <100.00%> (ø)
... and 49 more

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 31, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2025

This comment was marked as outdated.

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 31, 2025
@LiviaMedeiros LiviaMedeiros added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jun 1, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

@anonrig anonrig requested a review from LiviaMedeiros June 1, 2025 16:05
@anonrig
Copy link
Member Author

anonrig commented Jun 1, 2025

cc @LiviaMedeiros @jasnell can you re-review?

@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 26, 2025
@anonrig anonrig force-pushed the yagiz/enable-eslint-jsdoc branch from 9dbe731 to 0813c52 Compare July 14, 2025 00:01
@anonrig anonrig requested a review from aduh95 July 14, 2025 13:21
@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jul 15, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 15, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/58521
✔  Done loading data for nodejs/node/pull/58521
----------------------------------- PR info ------------------------------------
Title      meta: enable eslint jsdoc rules (#58521)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     anonrig:yagiz/enable-eslint-jsdoc -> nodejs:main
Labels     tools, author ready, commit-queue-squash
Commits    10
 - meta: enable jsdoc/check-tag-names rule
 - meta: enable jsdoc/no-defaults rule
 - meta: enable jsdoc/valid-types rule
 - meta: enable jsdoc/require-returns rule
 - fixup! meta: enable jsdoc/check-tag-names rule
 - meta: enable jsdoc/check-line-alignment rule
 - meta: enable jsdoc/check-alignment rule
 - Update source_map.js
 - Update eslint.config.mjs
 - fix eslint errors
Committers 1
 - Yagiz Nizipli <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58521
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58521
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 31 May 2025 00:31:26 GMT
   ✔  Approvals: 3
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58521#pullrequestreview-2882947324
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/58521#pullrequestreview-2885824763
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/58521#pullrequestreview-3018831710
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-06-01T16:43:29Z: https://ci.nodejs.org/job/node-test-pull-request/67232/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - meta: enable jsdoc/check-tag-names rule
   ⚠  - meta: enable jsdoc/no-defaults rule
   ⚠  - meta: enable jsdoc/valid-types rule
   ⚠  - meta: enable jsdoc/require-returns rule
   ⚠  - fixup! meta: enable jsdoc/check-tag-names rule
   ⚠  - meta: enable jsdoc/check-line-alignment rule
   ⚠  - meta: enable jsdoc/check-alignment rule
   ⚠  - Update source_map.js
   ⚠  - Update eslint.config.mjs
   ⚠  - fix eslint errors
- Querying data for job/node-test-pull-request/67232/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/16293920493

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants