module: add module.customConditions #57688

sapphi-red · 2025-03-30T08:47:20Z

Add module.customConditions which exposes the custom resolution conditions specified by the user.

Fixes: #55824

nodejs-github-bot · 2025-03-30T08:47:25Z

Review requested:

@nodejs/loaders

codecov · 2025-03-30T11:23:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (aad9030) to head (e87d6f5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57688      +/-   ##
==========================================
+ Coverage   89.96%   90.07%   +0.10%     
==========================================
  Files         640      640              
  Lines      188454   188489      +35     
  Branches    36892    36971      +79     
==========================================
+ Hits       169546   169781     +235     
+ Misses      11608    11422     -186     
+ Partials     7300     7286      -14

Files with missing lines	Coverage Δ
lib/module.js	`100.00% <100.00%> (ø)`

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/internal/modules/helpers.js

JakobJingleheimer

I think in order to address the primordial issue, you need to use SafeSet within getUserConditions, and then within the getter, wrap the output of getUserConditions in Set.

lib/module.js

This should help with nodejs#57688 and others

ljharb · 2025-04-01T20:59:19Z

I put up #57723 as a potential way to easily convert a SafeSet to a user-exposable Set, which might help this PR.

This should help with nodejs#57688 and others

sapphi-red · 2025-04-03T14:24:44Z

Thanks for the reviews!

lib/module.js

lib/internal/modules/helpers.js

lib/module.js

sapphi-red · 2025-04-06T12:35:06Z

Thanks, I've updated the code!

ljharb

How would i polyfill this in a node that doesn’t have it? Would i have to trawl through NODE_OPTIONS and process.argv and the config file, or is there an easier way?

sapphi-red · 2025-04-07T10:35:33Z

How would i polyfill this in a node that doesn’t have it? Would i have to trawl through NODE_OPTIONS and process.argv and the config file, or is there an easier way?

As far as I know, that’s the only way.

sapphi-red · 2025-04-15T03:43:33Z

The CI on Jenkins is failing, but I think the failure is not related to the change in this PR.
It's probably fixed by #57789. Should I rebase this PR on top of latest main branch?

sapphi-red · 2025-05-13T01:49:23Z

I’ve rebased the PR in case that was a blocker. Let me know if there’s anything else I should do.

guybedford

This seems sensible to me.

sapphi-red · 2025-06-21T08:29:32Z

@JakobJingleheimer Assuming that the blocker of this PR is the CI on Jenkins, would you re-trigger the CI?

nodejs-github-bot · 2025-06-21T14:43:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67590/

lib/module.js

test/parallel/test-module-customConditions.js

test/parallel/test-module-customConditions-single.js

test/parallel/test-module-customConditions-empty.js

nodejs-github-bot · 2025-06-29T21:40:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67731/

jsumners-nr

I think https://github.com/sapphi-red/node/blob/05d07dfb01ad34bfe1d236505b627d6f4465fd74/doc/api/cli.md?plain=1#L477-L502 will need to be updated.

I have never heard of this CLI option before, and neither the docs in this PR nor the docs I have linked make things clear to me.

doc/api/module.md

Add module.customConditions which exposes the custom resolution conditions specified by the user. Fixes: nodejs#55824

nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Mar 30, 2025

sapphi-red force-pushed the module/custom-conditions branch 2 times, most recently from 9efaba7 to 6f23b07 Compare March 30, 2025 08:55

targos reviewed Mar 31, 2025

View reviewed changes

lib/internal/modules/helpers.js Outdated Show resolved Hide resolved

sapphi-red force-pushed the module/custom-conditions branch from 6f23b07 to 6bbb2e1 Compare April 1, 2025 11:18

ljharb added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 1, 2025

JakobJingleheimer reviewed Apr 1, 2025

View reviewed changes

lib/module.js Outdated Show resolved Hide resolved

ljharb mentioned this pull request Apr 1, 2025

lib: add SafeSet.prototype.toUnsafeSet #57723

Closed

ljharb added a commit to ljharb/node that referenced this pull request Apr 1, 2025

lib: add SafeSet.prototype.toUnsafeSet

92a68f2

This should help with nodejs#57688 and others

ljharb added a commit to ljharb/node that referenced this pull request Apr 1, 2025

lib: add SafeSet.prototype.toUnsafeSet

fe02c30

This should help with nodejs#57688 and others

sapphi-red force-pushed the module/custom-conditions branch from 6bbb2e1 to cae9e94 Compare April 3, 2025 14:19

sapphi-red commented Apr 3, 2025

View reviewed changes

lib/module.js Outdated Show resolved Hide resolved

aduh95 reviewed Apr 3, 2025

View reviewed changes

lib/module.js Show resolved Hide resolved

aduh95 reviewed Apr 3, 2025

View reviewed changes

lib/internal/modules/helpers.js Outdated Show resolved Hide resolved

aduh95 reviewed Apr 3, 2025

View reviewed changes

lib/module.js Outdated Show resolved Hide resolved

sapphi-red force-pushed the module/custom-conditions branch 3 times, most recently from 66cc00b to 0789c21 Compare April 6, 2025 12:27

JakobJingleheimer approved these changes Apr 6, 2025

View reviewed changes

ljharb approved these changes Apr 7, 2025

View reviewed changes

JakobJingleheimer added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2025

This comment was marked as outdated.

Sign in to view

sapphi-red force-pushed the module/custom-conditions branch from 0789c21 to 21d5f0c Compare May 13, 2025 01:38

guybedford approved these changes May 15, 2025

View reviewed changes

sapphi-red mentioned this pull request Jun 12, 2025

Add a way to get the enabled conditions #55824

Closed

marco-ippolito approved these changes Jun 21, 2025

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2025

This comment was marked as outdated.

Sign in to view

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 21, 2025

jasnell reviewed Jun 21, 2025

View reviewed changes

lib/module.js Show resolved Hide resolved

jasnell reviewed Jun 21, 2025

View reviewed changes

test/parallel/test-module-customConditions.js Outdated Show resolved Hide resolved

sapphi-red force-pushed the module/custom-conditions branch 2 times, most recently from cac31a9 to 0986bde Compare June 23, 2025 04:03

jasnell reviewed Jun 24, 2025

View reviewed changes

test/parallel/test-module-customConditions-single.js Show resolved Hide resolved

jasnell approved these changes Jun 24, 2025

View reviewed changes

sapphi-red force-pushed the module/custom-conditions branch 2 times, most recently from be5a488 to 05d07df Compare June 25, 2025 03:05

jasnell reviewed Jun 29, 2025

View reviewed changes

test/parallel/test-module-customConditions-empty.js Outdated Show resolved Hide resolved

jsumners-nr reviewed Jun 30, 2025

View reviewed changes

doc/api/module.md Outdated Show resolved Hide resolved

sapphi-red force-pushed the module/custom-conditions branch from 05d07df to 861529e Compare July 4, 2025 04:21

module: add module.customConditions

e87d6f5

Add module.customConditions which exposes the custom resolution conditions specified by the user. Fixes: nodejs#55824

sapphi-red force-pushed the module/custom-conditions branch from 861529e to e87d6f5 Compare July 4, 2025 04:29

jsumners-nr approved these changes Jul 7, 2025

View reviewed changes

Uh oh!

module: add module.customConditions #57688

Are you sure you want to change the base?

module: add module.customConditions #57688

Uh oh!

Conversation

sapphi-red commented Mar 30, 2025

Uh oh!

nodejs-github-bot commented Mar 30, 2025

Uh oh!

codecov bot commented Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ljharb commented Apr 1, 2025

Uh oh!

sapphi-red commented Apr 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Apr 6, 2025

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

sapphi-red commented Apr 7, 2025

Uh oh!

sapphi-red commented Apr 15, 2025

Uh oh!

sapphi-red commented May 13, 2025

Uh oh!

guybedford left a comment

Choose a reason for hiding this comment

Uh oh!

sapphi-red commented Jun 21, 2025

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jun 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 29, 2025

Uh oh!

jsumners-nr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 30, 2025 •

edited

Loading