feat(media-volume): add media and volume keybinds with configurable volume steps - #23
Open
GhostEagle68 wants to merge 3 commits into
Open
feat(media-volume): add media and volume keybinds with configurable volume steps#23GhostEagle68 wants to merge 3 commits into
GhostEagle68 wants to merge 3 commits into
Conversation
… step Add commented-out media and volume keybinds to examples/config.toml so users can see how to wire up volume control with wpctl and media playback with playerctl. The volume step (5%) is a single number users change to their preference. Update docs/user/keybinds.md to use wpctl directly instead of noctalia for the volume example, with a comment clarifying the step size pattern. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add commented-out media and volume keybinds to
examples/config.tomlso users can see how to wire up volume control withwpctland media playback withplayerctl. The volume step is a single number users change to their preference.Update
docs/user/keybinds.mdto usewpctldirectly instead ofnoctalia msgfor the volume example, with a comment clarifying the step size pattern. Add a note that XF86 keys can be remapped to any chord.Motivation
The default config had no media or volume keybinds, and the docs example depended on Noctalia for volume. Users without Noctalia or without dedicated media keys had no guidance on how to set up audio controls.
Type of Change
Testing
umbriel validate -c examples/config.toml— passesjust format— no C++ changeswpctlandplayerctlin a running sessionManual Coverage
Checklist
CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.