fix(privacy): detect screen captures from xdg-desktop-portal-wlr - #4074
Open
benoitjpnet wants to merge 1 commit into
Open
fix(privacy): detect screen captures from xdg-desktop-portal-wlr#4074benoitjpnet wants to merge 1 commit into
benoitjpnet wants to merge 1 commit into
Conversation
The wlr portal names its stream nodes `xdpw-stream-*` (e.g. xdpw-stream-heAokj) which did not match any screen-share name heuristic, so the privacy widget and OSD never showed the screen-capture icon while sharing through it (used by wlroots-based and other compositors like niri). Add `xdpw-stream` to the recognized screen-share name prefixes.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The privacy widget and OSD never show the screen-capture icon while sharing the screen through
xdg-desktop-portal-wlr.Screen-share detection in
src/pipewire/pipewire_service.cpprelies on node-name heuristics (kScreenShareNamePrefixesetc.).xdg-desktop-portal-wlrnames its stream nodesxdpw-stream-<random>(verified:media.name = xdpw-stream-heAokj), which matches none of the existing prefixes/fragments:xdph-streaming(Hyprland portal) is checked, but notxdpw-stream(wlr portal)media.role, so classification falls through to the name heuristics and failsRepro
xdg-desktop-portal-wlrVideo/Sourcenodexdpw-stream-*linked toStream/Input/Video— privacy widget/OSD show nothingFix
Add
xdpw-streamtokScreenShareNamePrefixes. Mic and camera detection are unaffected.