fix(ui): clamp drag previews to overlay bounds - #4069
Open
Radium000 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
When a drag preview reached an overlay boundary, it could either stop moving
completely or remain partially outside the overlay.
Node::mapFromScene()still calculates the local coordinates when the pointeris outside the overlay, but returns
falsebecause the mapped point is notcontained by the node.
DragDropController::updatePreview()previouslydiscarded the entire update in that case.
This also prevented movement along the unaffected axis. For example, after
reaching the left edge, moving the pointer vertically no longer moved the
preview.
The new behavior uses the calculated coordinates and clamps each axis
independently. The preview therefore remains fully visible while continuing
to follow pointer movement parallel to the overlay edge.
Type of Change
Related Issue
N/A — reproduced and verified locally against Noctalia v5.
Testing
just formatwith clang-format 22.1.8.just test debug --print-errorlogs: 91/91 tests passed.