fix(nix): wrap gsettings-desktop-schemas - #4061
Open
nicobonada wants to merge 1 commit into
Open
Conversation
Tray IconName lookup uses GSettings (org.gnome.desktop.interface). glib does not ship that schema, so on NixOS without GNOME the resolver only searches hicolor and themed names (e.g. battery-090) fall back to the menu-2 glyph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefix
gsettings-desktop-schemasontoXDG_DATA_DIRSin the existingwrapProgram(same pattern asgitonPATH).Motivation
Tray
IconNamelookup uses GSettings (org.gnome.desktop.interface).glib does not ship that schema. On NixOS without GNOME it is also not
on the session profile, so IconResolver only searches hicolor.
Apps that advertise a themed name and no pixmap (e.g. Solaar
battery-090) then miss and the tray falls back to themenu-2glyph.Type of Change
Related Issue
None open that I could find. Closest prior report is #2859 (hamburger
after a restart); that was SNI re-registration, not schema lookup.
Testing
nix build .#default…/gsettings-desktop-schemas-*/share/gsettings-schemas/…gsettings get org.gnome.desktop.interface icon-themeisNo schemas installedwithout the prefix,'Papirus-Dark'with itstill published
IconName=battery-090, tray showed the Papirusbattery glyph instead of
menu-2Manual Coverage
Screenshots / Videos
Happy to attach a before/after of the tray (hamburger → battery).
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
nixpkgs GNOME packaging (
doc/languages-frameworks/gnome.section.md)would normally use
wrapGAppsNoGuiHookso the glib setup hook can putGSETTINGS_SCHEMAS_PATHonXDG_DATA_DIRS.This package already
wrapPrograms forgit. Using that hook heremeans
dontWrapGAppsplus splicinggappsWrapperArgsinto the existingwrapper, and it also injects
$out/share, default/usr/share, anddconf.libonGIO_EXTRA_MODULES. One explicit--prefix XDG_DATA_DIRSis the single path we need, same style as the git wrap.