fix(brightness): honor explicit backlight mapping fallback - #4056
Open
Nivella-Raven wants to merge 1 commit into
Open
fix(brightness): honor explicit backlight mapping fallback#4056Nivella-Raven wants to merge 1 commit into
Nivella-Raven wants to merge 1 commit into
Conversation
Use the configured per-output backlight device when automatic DRM/sysfs connector discovery cannot match a platform backlight to an active output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backlight_devicewhen automatic DRM/sysfs connector discovery cannot match a backlight to an active output.noneandddcutilbackend preferences during fallback selection.Motivation
Platform backlights do not necessarily have a DRM connector in their sysfs ancestry. On a ClockworkPi uConsole, the internal display uses this topology:
The output is explicitly configured:
However, backlight enumeration currently skips the device when automatic connector resolution fails, before consulting
backlight_device. This means the explicit mapping cannot recover from the missing DRM ancestry.This change consults active outputs for a matching explicit device only after automatic discovery fails. The selected candidate remains marked as a fallback rather than an exact DRM match.
Type of Change
Related Issue
Related context: #1898, #1899, and #3160.
Testing
Commands run on current
main:just format just configure just build just test git diff --checkResults:
Manual Coverage
Screenshots / Videos
Not applicable; this change has no visual UI component.
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
No new configuration key or user-facing string is introduced. This fixes fallback handling for the existing per-monitor
backlight_deviceoption.