feat(notification): route to source app output - #4045
Open
Accel-White wants to merge 1 commit into
Open
Conversation
Add an opt-in notification setting that selects the uniquely matched source application's eligible output and otherwise preserves the existing monitor behavior.
Accel-White
marked this pull request as ready for review
August 21, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notification.route_to_source_outputsetting and matching Notifications → Toasts toggleMotivation
On multi-monitor desktops, the source application can be on one output while focus is on another. Mirroring the same notification on every selected output is distracting, while focus-based routing can send it away from the source application.
Type of Change
Related Issue
Closes #4043
Testing
just formatfind src tests \( -name '*.cpp' -o -name '*.h' \) -print0 | xargs -0 clang-format --dry-run -Werrorjust buildjust test debug --print-errorlogs— 91/91 passedpython3 tools/i18n-check.pygit diff --checkDP-1output while Alacritty held focus onHDMI-A-2Manual Coverage
The manual routing check used outputs at 1.0 and 1.25 scale. The PR branch was also built and exercised by the full automated test suite on current
main.Screenshots / Videos
Not attached because the full-desktop capture contained unrelated private content. The live check confirmed one toast on the matched output and no duplicate on the other output.
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
notification.monitorsremains the allow-list. Routing only selects a target inside that list.Desktop notifications do not carry a portable originating toplevel identifier. If the same application has windows on multiple eligible outputs, this intentionally falls back to the current selected-monitor behavior instead of choosing an arbitrary window.