feat(calendar): support per-event colors from RFC 7986 and vendor extensions - #4033
Open
xela-zone wants to merge 1 commit into
Open
feat(calendar): support per-event colors from RFC 7986 and vendor extensions#4033xela-zone wants to merge 1 commit into
xela-zone wants to merge 1 commit into
Conversation
…ensions - Parse RFC 7986 'COLOR' property and CSS color specifications in ICalParser - Parse 'X-APPLE-CALENDAR-COLOR', 'X-COLOR', and 'X-OUTLOOK-COLOR' properties - Map Google Calendar per-event 'colorId' palette in GoogleClient - Use account/collection color as fallback only when event.colorHex is empty - Add unit tests for RFC COLOR, CSS named color, and vendor color parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
events could only previously have a single color - that of it's parent calendar account. this change allows that event to have a override color, by event.
Type of Change
Testing
using caldav + fastmail, and pr #4034
Manual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
generated using antigravity/gemini, tested and lead by a human