fix(bar): update widget selection index after deletion - #4022
Open
Aron-dxd wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes selection state of widgets when deleting a widget from a lane in Bar Widget Editor. Removing a widget kept the tokens in
selectedLaneWidgets, causing ghost selections and widgets being selected when the same deleted widget was added again. The deleted widget's token should now be pruned and higher indexes shifted down.Motivation
When users had one or more widgets widgets selected and removed one, the selection persisted. Later, when the same widget was added back, they remained selected. This causes visual inconsistencies and unpredictable behavior.
Type of Change
Related Issue
Testing
just format,just buildandjust run.Manual Coverage
Screenshots / Videos
Before:
recording_20260820_000401.mp4
After:
recording_20260820_001942.mp4
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes