feat(wallpaper): sync wallpaper with light/dark theme - #4011
Open
mdj2812 wants to merge 10 commits into
Open
Conversation
Introduce wallpaper.theme_sync settings for per-theme wallpaper paths, including optional per-monitor overrides. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve, query, and persist light/dark wallpaper bindings, with unit tests for global and per-monitor overrides. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply theme-bound paths on startup and theme transitions, debounce startup races, seed bindings when sync is enabled, and skip automation for outputs with active bindings. Co-authored-by: Cursor <cursoragent@cursor.com>
Expose sync wallpaper with theme in wallpaper settings and document that bindings are assigned from the wallpaper panel. Co-authored-by: Cursor <cursoragent@cursor.com>
Bind wallpapers to the active Dark or Light tab on selection, refresh the browse directory when switching tabs, and show theme sync badges. Co-authored-by: Cursor <cursoragent@cursor.com>
Use the resolved light/dark appearance when the Auto tab is active so picking a wallpaper updates the binding instead of being skipped. Co-authored-by: Cursor <cursoragent@cursor.com>
When the wallpaper panel or wallpaper-set targets every output, write per-monitor theme sync paths alongside the global binding so existing monitor overrides do not mask the new pick. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep path_light/path_dark in sync when binding a single monitor so automation guards and all-monitor lookups see the binding. Add unit tests for monitor-only gaps and single-monitor writes. Co-authored-by: Cursor <cursoragent@cursor.com>
Centralize manual-pick and seed binding helpers in wallpaper_paths, stop auto-enabling theme sync on panel picks, and expand unit test coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
mdj2812
marked this pull request as draft
August 19, 2026 05:47
Co-authored-by: Cursor <cursoragent@cursor.com>
mdj2812
marked this pull request as ready for review
August 19, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[wallpaper.theme_sync]config with global and per-monitorpath_light/path_darkbindings, plus a settings toggleCloses #1612
Test plan
wallpaper_theme_sync_paths_test)wallpaper-setupdates bindings for resolved mode; theme mode switch applies bound wallpapersrecording_20260819_140519.mp4
Made with Cursor