fix(khal-events): add subprocess timeout to prevent DoS#2322
Open
cbxcvl wants to merge 1 commit intonoctalia-dev:mainfrom
Open
fix(khal-events): add subprocess timeout to prevent DoS#2322cbxcvl wants to merge 1 commit intonoctalia-dev:mainfrom
cbxcvl wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
subprocess.run was called without a timeout, allowing callers to pass unbounded durations and hang the process indefinitely. Adds a 30s timeout with graceful handling of TimeoutExpired, and skips empty lines in khal output to prevent JSON parse errors. Reported and patched with @pa1va. Closes noctalia-dev#2321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the DoS bug reported in #2321.
subprocess.runwas called without atimeout, allowing any caller to pass an unbounded duration (e.g.999999d) and hang the process indefinitely. Confirmed: process blocked for 98+ seconds beforeKeyboardInterrupt.Changes
timeout=30tosubprocess.runsubprocess.TimeoutExpiredhandler — exits with code 1 and prints[]to stderrJSONDecodeErrorTest
Closes #2321
Contributors: @cbxcvl @pa1va