Allow to totally hide password in lockscreen#2301
Open
tmarti2 wants to merge 1 commit intonoctalia-dev:mainfrom
Open
Allow to totally hide password in lockscreen#2301tmarti2 wants to merge 1 commit intonoctalia-dev:mainfrom
tmarti2 wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
Contributor
Author
|
I wanted to do that, but without it you do not have any feedback at all that the password field is focused and that typing actually works (well, the "show password" icons appears but I don't feel it's enough) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request
Motivation
It was suggested as a feature to be able to totally hide the password in lockscreen so that even its length could not be seen, in public for instance.
This MR replaces the toggle setting for circle/random with a combo which adds invisible as an option. It's not invisible icon per se, just that we do not draw anything. This MR replaces the other setting (and modifies I18n entries), so it will be reset to the default value (circle) for people that had random enabled.
Type of Change
Mark the relevant option with an "x".
Related Issue
Testing
Describe how you tested your changes and mark the relevant items.
Checklist