Skip to content

feat(Linux WallpaperEngine Controller) Enhance panel localization and UI clarity across multiple languages#596

Open
PaloMiku wants to merge 12 commits intonoctalia-dev:mainfrom
PaloMiku:main
Open

feat(Linux WallpaperEngine Controller) Enhance panel localization and UI clarity across multiple languages#596
PaloMiku wants to merge 12 commits intonoctalia-dev:mainfrom
PaloMiku:main

Conversation

@PaloMiku
Copy link
Copy Markdown
Contributor

@PaloMiku PaloMiku commented Apr 8, 2026

(The PR description was generated by Github Copilot.)

This pull request introduces several user experience improvements and internationalization updates to the linux-wallpaperengine-controller project. The main changes include adding user feedback (toast notifications) for reload and stop actions, refining and expanding translation strings in English, Japanese, Chinese, and adding a new Russian translation. There are also minor UI/UX text adjustments and improvements to the settings' unit labels.

User Feedback Enhancements

  • Added toast notifications for reload and stop actions, including handling the case where reload is skipped due to no configured wallpaper. These notifications are shown in the user's language and provide immediate feedback for these actions. (Main.qml, BarWidget.qml, en.json, ja.json, zh-CN.json, ru.json)

Internationalization and Localization

  • Added a complete Russian translation file, covering all UI elements and messages. (ru.json)
  • Updated and expanded English, Japanese, and Chinese translation files: improved section titles, button labels, filter/sort options, and added new strings for toast messages and UI feedback. (en.json, ja.json, zh-CN.json)
  • Adjusted UI text for clarity and consistency, such as renaming section titles, button labels, and adding more descriptive messages for empty states and actions. (en.json, ja.json, zh-CN.json)

Settings and Units

  • Updated settings sliders to use translated unit suffixes for FPS and percent, improving localization and clarity in the settings panel. (Settings.qml, en.json, ja.json, zh-CN.json, ru.json)

Code Maintenance

  • Minor code refactoring to support the new toast notification logic by passing a flag to reload and stopAll functions. (Main.qml, BarWidget.qml)

Preview Panel (New):

图片

Copilot AI review requested due to automatic review settings April 8, 2026 12:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the wallpaper selection panel’s UX and localization by adding toast feedback for engine actions, expanding translations (including a new Russian locale), and refining panel UI elements (filters, badges, and multi-display targeting).

Changes:

  • Add localized toast notifications for reload/stop actions (including “reload skipped”).
  • Enhance the panel UI with resolution filtering, clearer badges/labels, and an updated multi-display target selector.
  • Expand i18n strings across EN/JA/ZH + add RU, and localize unit suffixes in settings.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
linux-wallpaperengine-controller/Main.qml Adds optional toast feedback to reload() / stopAll() and imports Toast service.
linux-wallpaperengine-controller/BarWidget.qml Triggers toast-enabled reload/stop from the bar widget context actions.
linux-wallpaperengine-controller/Panel.qml Adds resolution filtering UI, new badges, refactors apply-target UI, and updates empty-state messaging.
linux-wallpaperengine-controller/Settings.qml Localizes FPS/% unit suffixes via translation keys.
linux-wallpaperengine-controller/manifest.json Bumps plugin version to 1.1.0.
linux-wallpaperengine-controller/i18n/en.json Adds toast + new panel strings, updates wording, adds unit strings.
linux-wallpaperengine-controller/i18n/ja.json Adds toast + new panel strings, updates wording, adds unit strings.
linux-wallpaperengine-controller/i18n/zh-CN.json Adds toast + new panel strings, updates wording, adds unit strings.
linux-wallpaperengine-controller/i18n/zh-TW.json Adds toast + new panel strings, updates wording, adds unit strings.
linux-wallpaperengine-controller/i18n/ru.json New full Russian translation coverage including toast + units.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PaloMiku
Copy link
Copy Markdown
Contributor Author

PaloMiku commented Apr 9, 2026

I think it's pretty good now (current version 1.1.2).

Copy link
Copy Markdown
Contributor

@spiros132 spiros132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :D

@ItsLemmy

{
"id": "linux-wallpaperengine-controller",
"name": "Linux WallpaperEngine Controller",
"version": "1.0.6",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is sus?
the sementic release is normally done with minor and major patches. it looks like you're doing two patches and one minor. when a minor is made in a pr it includes the patches

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I developed this PR iteratively: first a few small fixes, then a larger UI improvement.

I previously conducted multiple rounds of small-scale testing in my personal repository, resulting in multiple version iterations.

I won't change it frequently after that

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay mb 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants