Skip to content

Bug..fix? #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lakshmipathyarjun6 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug..fix? #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/geometrycentral/surface/vector_heat_method.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class VectorHeatMethodSolver {


// === The Logarithmic map
VertexData<Vector2> computeLogMap(const Vertex& sourceVert, double vertexDistanceShift = 0.);
VertexData<Vector2> computeLogMap(const Vertex& sourceVert, double vertexDistanceShift = 0., double vertAngleRad = 0.);
VertexData<Vector2> computeLogMap(const SurfacePoint& sourceP);


Expand Down
4 changes: 2 additions & 2 deletions src/surface/vector_heat_method.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ VectorHeatMethodSolver::transportTangentVectors(const std::vector<std::tuple<Sur
}


VertexData<Vector2> VectorHeatMethodSolver::computeLogMap(const Vertex& sourceVert, double vertexDistanceShift) {
VertexData<Vector2> VectorHeatMethodSolver::computeLogMap(const Vertex& sourceVert, double vertexDistanceShift, double vertAngleRad) {
geom.requireFaceAreas();
geom.requireEdgeLengths();
geom.requireCornerAngles();
Expand Down Expand Up @@ -284,7 +284,7 @@ VertexData<Vector2> VectorHeatMethodSolver::computeLogMap(const Vertex& sourceVe

// Build rhs
Vector<std::complex<double>> horizontalRHS = Vector<std::complex<double>>::Zero(mesh.nVertices());
horizontalRHS[geom.vertexIndices[sourceVert]] += 1.0;
horizontalRHS[geom.vertexIndices[sourceVert]] = -1.0 * (cos(vertAngleRad) + sin(vertAngleRad) * 1i);

// Solve
Vector<std::complex<double>> horizontalSol = vectorHeatSolver->solve(horizontalRHS);
Expand Down