Skip to content

Added permission checks to custom JS and CSS in posts meta editor #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nk-o merged 4 commits into from
Sep 11, 2025
Merged

Added permission checks to custom JS and CSS in posts meta editor #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e71c8b
added permission checks to custom JS and CSS in posts meta editor
nk-o Sep 7, 2025
0713fb5
fixed auth check when changing custom meta
nk-o Sep 7, 2025
7eafe07
build
nk-o Sep 7, 2025
d4a6c83
Update typography.spec.js
nk-o Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/gutenberg/index.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('jquery', 'lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-keycodes', 'wp-notices', 'wp-plugins', 'wp-rich-text', 'wp-token-list'), 'version' => 'ce0f34e6951be5eef8d0');
<?php return array('dependencies' => array('jquery', 'lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-keycodes', 'wp-notices', 'wp-plugins', 'wp-rich-text', 'wp-token-list'), 'version' => '9cc863f7d0d63c97d9f1');
6 changes: 3 additions & 3 deletions build/gutenberg/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/gutenberg/plugins.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins'), 'version' => '7729527bebaa317504c0');
<?php return array('dependencies' => array('lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins'), 'version' => 'dc62af91e36b9ee0c77c');
2 changes: 1 addition & 1 deletion build/gutenberg/plugins.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/settings/index.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-library', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n'), 'version' => 'a333b2329a5aed1619b4');
<?php return array('dependencies' => array('lodash', 'react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-library', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n'), 'version' => 'c7aed1f811a0a2f68241');
2 changes: 1 addition & 1 deletion build/settings/index.js
View file
Open in desktop

Large diffs are not rendered by default.

224 changes: 142 additions & 82 deletions gutenberg/plugins/custom-code/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import apiFetch from '@wordpress/api-fetch';
import { TabPanel, Tooltip } from '@wordpress/components';
import { Notice, TabPanel, Tooltip } from '@wordpress/components';
import { compose } from '@wordpress/compose';
import { withDispatch, withSelect } from '@wordpress/data';
import { PluginMoreMenuItem } from '@wordpress/editor';
Expand Down Expand Up @@ -55,7 +55,13 @@ class CustomCodeModal extends Component {
}

render() {
const { updateMeta, updateCustomCode, onRequestClose } = this.props;
const {
updateMeta,
updateCustomCode,
onRequestClose,
canEditCustomJS,
canEditGlobalCustomCode,
} = this.props;

return (
<Modal
Expand All @@ -74,15 +80,17 @@ class CustomCodeModal extends Component {
newLocal.ghostkit_custom_css = this.state.customCSS;
}
if (
canEditCustomJS &&
this.state.customJSHead !==
local.ghostkit_custom_js_head
local.ghostkit_custom_js_head
) {
newLocal.ghostkit_custom_js_head =
this.state.customJSHead;
}
if (
canEditCustomJS &&
this.state.customJSFoot !==
local.ghostkit_custom_js_foot
local.ghostkit_custom_js_foot
) {
newLocal.ghostkit_custom_js_foot =
this.state.customJSFoot;
Expand All @@ -93,22 +101,25 @@ class CustomCodeModal extends Component {

// Global
if (
canEditGlobalCustomCode &&
this.state.globalCustomCSS !==
global.ghostkit_custom_css
global.ghostkit_custom_css
) {
newGlobal.ghostkit_custom_css =
this.state.globalCustomCSS;
}
if (
canEditGlobalCustomCode &&
this.state.globalCustomJSHead !==
global.ghostkit_custom_js_head
global.ghostkit_custom_js_head
) {
newGlobal.ghostkit_custom_js_head =
this.state.globalCustomJSHead;
}
if (
canEditGlobalCustomCode &&
this.state.globalCustomJSFoot !==
global.ghostkit_custom_js_foot
global.ghostkit_custom_js_foot
) {
newGlobal.ghostkit_custom_js_foot =
this.state.globalCustomJSFoot;
Expand Down Expand Up @@ -161,80 +172,120 @@ class CustomCodeModal extends Component {
return (
<>
<h4>{__('CSS', 'ghostkit')}</h4>
<CodeEditor
mode="css"
onChange={(value) => {
this.setState({
[isGlobal
? 'globalCustomCSS'
: 'customCSS']: value,
});
}}
value={
(isGlobal
? this.state.globalCustomCSS
: this.state.customCSS) || ''
}
maxLines={20}
minLines={5}
height="300px"
/>
{isGlobal && !canEditGlobalCustomCode ? (
<Notice
status="warning"
isDismissible={false}
>
{__(
"You don't have permissions to edit global custom code.",
'ghostkit'
)}
</Notice>
) : (
<CodeEditor
mode="css"
onChange={(value) => {
this.setState({
[isGlobal
? 'globalCustomCSS'
: 'customCSS']: value,
});
}}
value={
(isGlobal
? this.state.globalCustomCSS
: this.state.customCSS) || ''
}
maxLines={20}
minLines={5}
height="300px"
/>
)}

<h4>{__('JavaScript', 'ghostkit')}</h4>
<p className="ghostkit-help-text">
{__(
'Add custom JavaScript code in <head> section or in the end of <body> tag. Insert Google Analytics, Tag Manager or other JavaScript code snippets.',
'ghostkit'
)}
</p>
<p>
<code className="ghostkit-code">
{'<head>'}
</code>{' '}
:
</p>
<CodeEditor
mode="javascript"
onChange={(value) => {
this.setState({
[isGlobal
? 'globalCustomJSHead'
: 'customJSHead']: value,
});
}}
value={
(isGlobal
? this.state.globalCustomJSHead
: this.state.customJSHead) || ''
}
maxLines={20}
minLines={5}
height="300px"
/>
<p>
<code className="ghostkit-code">
{'<foot>'}
</code>{' '}
:
</p>
<CodeEditor
mode="javascript"
onChange={(value) => {
this.setState({
[isGlobal
? 'globalCustomJSFoot'
: 'customJSFoot']: value,
});
}}
value={
(isGlobal
? this.state.globalCustomJSFoot
: this.state.customJSFoot) || ''
}
maxLines={20}
minLines={5}
height="300px"
/>
{(!isGlobal && canEditCustomJS) ||
(isGlobal &&
canEditGlobalCustomCode &&
canEditCustomJS) ? (
<>
<p className="ghostkit-help-text">
{__(
'Add custom JavaScript code in <head> section or in the end of <body> tag. Insert Google Analytics, Tag Manager or other JavaScript code snippets.',
'ghostkit'
)}
</p>
<p>
<code className="ghostkit-code">
{'<head>'}
</code>{' '}
:
</p>
<CodeEditor
mode="javascript"
onChange={(value) => {
this.setState({
[isGlobal
? 'globalCustomJSHead'
: 'customJSHead']:
value,
});
}}
value={
(isGlobal
? this.state
.globalCustomJSHead
: this.state
.customJSHead) || ''
}
maxLines={20}
minLines={5}
height="300px"
/>
<p>
<code className="ghostkit-code">
{'<foot>'}
</code>{' '}
:
</p>
<CodeEditor
mode="javascript"
onChange={(value) => {
this.setState({
[isGlobal
? 'globalCustomJSFoot'
: 'customJSFoot']:
value,
});
}}
value={
(isGlobal
? this.state
.globalCustomJSFoot
: this.state
.customJSFoot) || ''
}
maxLines={20}
minLines={5}
height="300px"
/>
</>
) : (
<Notice
status="warning"
isDismissible={false}
>
{isGlobal
? __(
"You don't have permissions to edit global custom code.",
'ghostkit'
)
: __(
"You don't have permissions to edit custom JavaScript code.",
'ghostkit'
)}
</Notice>
)}
</>
);
}}
Expand All @@ -246,16 +297,25 @@ class CustomCodeModal extends Component {

const CustomCodeModalWithSelect = compose([
withSelect((select) => {
// Check user permissions (from localized variables)
const canEditCustomJS =
window.ghostkitVariables?.canEditCustomJS ?? true;
const canEditGlobalCustomCode =
window.ghostkitVariables?.canEditGlobalCustomCode ?? true;

const currentMeta =
select('core/editor').getCurrentPostAttribute('meta');
const editedMeta = select('core/editor').getEditedPostAttribute('meta');
const customCode = select(
'ghostkit/plugins/custom-code'
).getCustomCode();

const customCode = canEditGlobalCustomCode
? select('ghostkit/plugins/custom-code').getCustomCode()
: false;

return {
meta: { ...currentMeta, ...editedMeta },
customCode,
canEditCustomJS,
canEditGlobalCustomCode,
};
}),
withDispatch((dispatch) => ({
Expand Down
Loading
Loading