Skip to content

Conversation

khaneliman
Copy link
Collaborator

@khaneliman khaneliman commented Sep 19, 2025

Description

Just wondering if we think this would help users or if we should just add a note about how to configure it themselves with the package option?

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like the extraPackages option and use it with other modules. While it's not difficult to override the package, IMO it's more convenient for users to have this option, especially beginners.

@khaneliman khaneliman force-pushed the yazi branch 5 times, most recently from 7a3b3df to 2ff77f6 Compare September 19, 2025 20:42
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks!

@khaneliman khaneliman merged commit edc7468 into nix-community:master Sep 20, 2025
7 checks passed
@khaneliman khaneliman deleted the yazi branch September 21, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants