Skip to content

Conversation

in-a-dil-emma
Copy link

@in-a-dil-emma in-a-dil-emma commented Sep 5, 2025

Description

I have my history settings set via the NixOS module and I don't want to set those again for home-manager.

I admit this is a very specific usecase.

I'm open to suggestions on how to name that new option. I'm unsure myself.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@github-actions github-actions bot added the shell label Sep 5, 2025
Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of enableConfig, but I can see that history.enable might lead a user to believe it would disable the history feature entirely, rather than just not configure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants