Skip to content

Conversation

StijnRuts
Copy link

Description

Allow configuring settings.yaml, theme.yaml, and shortcuts.yaml for Process Compose

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@StijnRuts
Copy link
Author

It's failing with attribute 'stijnruts' missing on meta.maintainers = [ lib.maintainers.stijnruts ];, but I added myself to modules/lib/maintainers.nix. Does anyone know what I did wrong?

Allow configuring settings.yaml, theme.yaml, and shortcuts.yaml

Remove unused variables

Fix maintainers
source = yamlFormat.generate "process-compose-settings" cfg.settings;
};
"process-compose/theme.yaml" = lib.mkIf (cfg.theme != { }) {
source = yamlFormat.generate "process-compose-theme" { style = cfg.theme; };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this help / confuse people trying to use the option ? Seems like it's setup as a freeform generator but that automatically nests the config.

source = yamlFormat.generate "process-compose-theme" { style = cfg.theme; };
};
"process-compose/shortcuts.yaml" = lib.mkIf (cfg.shortcuts != { }) {
source = yamlFormat.generate "process-compose-shortcuts" { shortcuts = cfg.shortcuts; };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Comment on lines +504 to +509
stijnruts = {
name = "Stijn Ruts";
email = "[email protected]";
github = "StijnRuts";
githubId = 1696566;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate commit before module addition, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants