Allow draid in ZFS #1049
Open
Allow draid in ZFS #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 5, 2025
| name = "zpoolMode"; | ||
| description = "valid modes for a zpool"; | ||
| descriptionClass = "noun"; | ||
| check = (x: lib.isString x && (builtins.elem x modeOptions || lib.strings.hasPrefix "draid" x)); |
There was a problem hiding this comment.
What does example configuration for this looks like? Should we extend zfs-with-vdevs.nix ?
There was a problem hiding this comment.
it looks very similar to raidz, but the mode would look something like draid2:16d:27c:2s.
There was a problem hiding this comment.
Can you provide a more complete configuration that I can use for testing?
There was a problem hiding this comment.
{
lib,
...
}:
let
in
{
disko.devices = {
disk = {
"disk0" = {
type = "disk";
device = "/dev/mapper/disk0";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk1" = {
type = "disk";
device = "/dev/mapper/disk1";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk2" = {
type = "disk";
device = "/dev/mapper/disk2";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk3" = {
type = "disk";
device = "/dev/mapper/disk3";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk4" = {
type = "disk";
device = "/dev/mapper/disk4";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk5" = {
type = "disk";
device = "/dev/mapper/disk5";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk6" = {
type = "disk";
device = "/dev/mapper/disk6";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk7" = {
type = "disk";
device = "/dev/mapper/disk7";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk8" = {
type = "disk";
device = "/dev/mapper/disk8";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk9" = {
type = "disk";
device = "/dev/mapper/disk9";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk10" = {
type = "disk";
device = "/dev/mapper/disk10";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk11" = {
type = "disk";
device = "/dev/mapper/disk11";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk12" = {
type = "disk";
device = "/dev/mapper/disk12";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk13" = {
type = "disk";
device = "/dev/mapper/disk13";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk14" = {
type = "disk";
device = "/dev/mapper/disk14";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk15" = {
type = "disk";
device = "/dev/mapper/disk15";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk16" = {
type = "disk";
device = "/dev/mapper/disk16";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk17" = {
type = "disk";
device = "/dev/mapper/disk17";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk18" = {
type = "disk";
device = "/dev/mapper/disk18";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk19" = {
type = "disk";
device = "/dev/mapper/disk19";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk20" = {
type = "disk";
device = "/dev/mapper/disk20";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk21" = {
type = "disk";
device = "/dev/mapper/disk21";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk22" = {
type = "disk";
device = "/dev/mapper/disk22";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk23" = {
type = "disk";
device = "/dev/mapper/disk23";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk24" = {
type = "disk";
device = "/dev/mapper/disk24";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk25" = {
type = "disk";
device = "/dev/mapper/disk25";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
"disk26" = {
type = "disk";
device = "/dev/mapper/disk26";
content = {
type = "gpt";
partitions = {
zfs = {
size = "100%";
content = {
type = "zfs";
pool = "tank";
};
};
};
};
};
};
zpool = {
tank = {
type = "zpool";
mode = {
topology = {
type = "topology";
vdev = [
{
mode = "draid2:16d:27c:2s"; # according to my calculations, this is pretty optimal. Read the README for more info
members = [
"disk0"
"disk1"
"disk2"
"disk3"
"disk4"
"disk5"
"disk6"
"disk7"
"disk8"
"disk9"
"disk10"
"disk11"
"disk12"
"disk13"
"disk14"
"disk15"
"disk16"
"disk17"
"disk18"
"disk19"
"disk20"
"disk21"
"disk22"
"disk23"
"disk24"
"disk25"
"disk26"
];
}
];
};
};
datasets = {
mirror = {
type = "zfs_fs";
mountpoint = "/srv/mirror";
};
};
};
};
};
}
|
I'm not quite sure how to have the tests pass if the type is set to a function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, creating a draid pool in disko would fail with a type error. This simple patch should resolve that.