Skip to content

feat: grim reaper scythe swing, speech bubbles, and proximity reactions#84

Merged
nitrocode merged 1 commit into
mainfrom
copilot/add-grim-reaper-scene
Apr 26, 2026
Merged

feat: grim reaper scythe swing, speech bubbles, and proximity reactions#84
nitrocode merged 1 commit into
mainfrom
copilot/add-grim-reaper-scene

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 26, 2026

The grim reaper was a static decoration. This adds interactive behaviour: periodic scythe swings with a visual animation, speech bubbles with thematic quotes, and reactions to mouse proximity and clicks/taps.

Changes

HTML (index.html)

  • Wraps the scythe <line> + <path> in <g class="reaper-scythe-group"> to enable independent transform animation
  • Adds #reaper-bubble div inside #grim-reaper for the speech bubble

CSS (styles/scary-features.css)

  • @keyframes reaper-scythe-swing — multi-step arc (−26° → +20° → settle) pivoting at grip point via transform-box: fill-box; transform-origin: 84% 68%
  • .reaper-swinging .reaper-scythe-group — one-shot animation trigger class
  • .reaper-bubble / .reaper-bubble.visible — red-bordered speech bubble with CSS tail arrow, fade transition
  • .reaper-proximity .reaper-eye-inner — intensified eye glow when cursor is nearby
  • prefers-reduced-motion guards on all new animations

JS (src/js/18-scary-features.js + 21-boot.js)

  • initGrimReaper() wires three interaction modes:
    • Click/tap — cycles through 14 click quotes, swings scythe
    • Proximitymousemove listener throttled via rAF; triggers on cursor entering a ≤140 px / ≤100 px zone around the reaper; shows hover quote + swing, adds .reaper-proximity; correctly removes it on exit
    • IdlesetTimeout-chain fires every 25–55 s (randomised), shows one of 15 idle quotes + swing; guards against unbounded chain if element is removed
  • Quote pools: 15 idle, 14 click, 6 proximity

Tests (tests/e2e/death-clock.spec.js)

  • 3 new E2E assertions: bubble element present + hidden on load, click triggers visible bubble + scythe group, bubble auto-hides after timeout

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

Warning

Rate limit exceeded

@nitrocode has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 16 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 16 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 98673c05-6a8f-4819-aa16-36dc77897e90

📥 Commits

Reviewing files that changed from the base of the PR and between 875f272 and 641a5e9.

📒 Files selected for processing (5)
  • index.html
  • src/js/18-scary-features.js
  • src/js/21-boot.js
  • styles/scary-features.css
  • tests/e2e/death-clock.spec.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/add-grim-reaper-scene

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitrocode nitrocode marked this pull request as ready for review April 26, 2026 16:54
@nitrocode nitrocode self-requested a review as a code owner April 26, 2026 16:54
@github-actions
Copy link
Copy Markdown
Contributor

👁️ PR Preview

🚀 Open Preview

Deployed from commit 641a5e9 · Updates on every push to this PR
(Preview is removed automatically when the PR is closed.)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (200e880) to head (641a5e9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          242       242           
  Branches       109       109           
=========================================
  Hits           242       242           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200e880...641a5e9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nitrocode nitrocode merged commit 36a0725 into main Apr 26, 2026
10 checks passed
@nitrocode nitrocode deleted the copilot/add-grim-reaper-scene branch April 26, 2026 16:56
github-actions Bot added a commit that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants