GitHub Actions: Switch to cross-platform-actions to run tests in VMs
#1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the VM is sometimes stuck booting, long before executing any tests. The default timeout of 6 hours blocks other CI jobs for a very long time. Because the VM won't boot anyway, we reduce this time to one hour. One hour should be long enough for a successful slow execution of the tests.
dumbbell
force-pushed
the
set-timeout-for-check-in-vm
branch
4 times, most recently
from
9ecf7ce to
f308611
Compare
`vmactions` VM fails to boot quite frequently and we have no visibility
on the reason of the failure.
The only failure I got out-of-the-box with cross-platform-actions VM was
the `core-deps-rel` test case which hangs. It comes from the use of
`erl_call` to detect if the Erlang node was started correctly. A comment
in the generated release starts scripts says:
# users who depend on stdout when running rpc calls must still use nodetool
# so we have an overload option to force use of nodetool instead of erl_call
If `$USE_NODETOOL` is set, it will use `relx_nodetool` instead. Indeed,
this fixed the hang.
This is the same as `check`. The files of the cross-platform-actions VM are synchronised in both ways, so we can re-use the same configuration.
dumbbell
force-pushed
the
set-timeout-for-check-in-vm
branch
from
e471b53 to
a75e431
Compare
dumbbell
changed the title
check-in-vmcross-platform-actions to run tests in VMs
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vmactionsVM fails to boot quite frequently and we have no visibility on the reason of the failure.The only failure I got out-of-the-box with cross-platform-actions VM was the
core-deps-reltest case which hangs. It comes from the use oferl_callto detect if the Erlang node was started correctly. A comment in the generated release starts scripts says:If
$USE_NODETOOLis set, it will userelx_nodetoolinstead. Indeed, this fixed the hang.While here, set a timeout of one hour in case a VM even hangs again. Much more acceptable than the default 6 hours.
Also, in case of a test failure, upload the artifacts like it is already the case for Linux-based tests.