Optimize dep_fetch_hex on Windows
#1036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
optimize-dep_fetch_hex-on-windows
branch
3 times, most recently
from
6d857af to
9bc843c
Compare
|
The patch is ready. I don’t mark it as ready for review yet because it is based on the branch for #1035. |
dumbbell
force-pushed
the
optimize-dep_fetch_hex-on-windows
branch
from
9bc843c to
aff3f45
Compare
On Windows, this executes a shell to determine the native path, which is very expensive. The result is always the same, so make sure `core_native_path` is called once instead. For example, this saves a significant amount of time when compiling RabbitMQ on Windows.
dumbbell
force-pushed
the
optimize-dep_fetch_hex-on-windows
branch
from
aff3f45 to
94dba57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this by avoiding calling
core_native_pathin dep_fetch_hex many times.On Windows, this executes a shell to determine the native path, which is very expensive. The result is always the same, so make sure
core_native_pathis called once instead.For example, this saves a significant amount of time when compiling RabbitMQ on Windows.