Skip to content

Avoid some dangling nimsuggests - #448

Draft
nitely wants to merge 1 commit into
nim-lang:masterfrom
nitely:fix_nimsuggest_test_proc
Draft

Avoid some dangling nimsuggests#448
nitely wants to merge 1 commit into
nim-lang:masterfrom
nitely:fix_nimsuggest_test_proc

Conversation

@nitely

@nitely nitely commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Changes:

  • Keep track of starting nimsuggests to shut them down
  • Prevent spawning new nimsuggest instances if shutting down
  • Await for the nimsuggest instances to actually shutdown on exit
  • Running the tests no longer leave dangling nimsuggests instances

Likely merge #446 first, rebase this, and get rid of the nested waitFor this change adds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant