nils-org · renovate · Jan 20, 2025
diff --git a/src/JavaVersionSwitcher.Tests/JavaVersionSwitcher.Tests.csproj b/src/JavaVersionSwitcher.Tests/JavaVersionSwitcher.Tests.csproj
@@ -17,7 +17,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="6.0.3">
+    <PackageReference Include="coverlet.collector" Version="6.0.4">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>

diff --git a/src/JavaVersionSwitcher/Adapters/RegistryAdapter.cs b/src/JavaVersionSwitcher/Adapters/RegistryAdapter.cs
        return AsyncRegistryKey.Hklm;
    }

    internal class AsyncRegistryKey : IDisposable
    {
 #pragma warning disable CA1416
        private readonly RegistryKey _key;

        private AsyncRegistryKey(RegistryKey key)
        {
            get
            {
                return RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
                    ? Task.Factory.StartNew(() => new AsyncRegistryKey(Registry.LocalMachine))
                    : Task.Factory.StartNew<AsyncRegistryKey>(() => null);
            }
        }
diff --git a/src/JavaVersionSwitcher/Program.cs b/src/JavaVersionSwitcher/Program.cs
        
    private static ITypeRegistrar BuildRegistrar()
    {
        var container = new Container();
        container.Options.ResolveUnregisteredConcreteTypes = true;
        container.Register<ILogger, Logger>(Lifestyle.Singleton);

diff --git a/src/JavaVersionSwitcher/Adapters/ShellAdapter.cs b/src/JavaVersionSwitcher/Adapters/ShellAdapter.cs

        for (var index = 0; index < processesByName.Length; index++) {
            processIndexedName = index == 0 ? processName : processName + "#" + index;
            var processId = new PerformanceCounter("Process", "ID Process", processIndexedName);
            if ((int) processId.NextValue() == pid) {
                return processIndexedName;
            }
                "Accessing parent process is currently only available on windows.");
        }

        var parentId = new PerformanceCounter("Process", "Creating Process ID", indexedProcessName);
        return Process.GetProcessById((int) parentId.NextValue());
    }
 #pragma warning restore CA1416
diff --git a/src/JavaVersionSwitcher/Adapters/JavaInstallationsAdapter.cs b/src/JavaVersionSwitcher/Adapters/JavaInstallationsAdapter.cs
        
    private async Task<Tuple<string, string>> GetVersion(string javaExePath)
    {
        var proc = new Process
        {
            StartInfo = new ProcessStartInfo
            {
	return AsyncRegistryKey.Hklm;
	}

	internal class AsyncRegistryKey : IDisposable
Check warning on line 26 in src/JavaVersionSwitcher/Adapters/RegistryAdapter.cs GitHub Actions / build (windows-2022) `Class with no virtual dispose method should be sealed (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP025.md)` Check warning on line 26 in src/JavaVersionSwitcher/Adapters/RegistryAdapter.cs GitHub Actions / build (windows-2022) `Class with no virtual dispose method should be sealed (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP025.md)`
	{
	#pragma warning disable CA1416
	private readonly RegistryKey _key;
Check warning on line 29 in src/JavaVersionSwitcher/Adapters/RegistryAdapter.cs GitHub Actions / build (windows-2022) `Don't assign member with injected and created disposables (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP008.md)`

	private AsyncRegistryKey(RegistryKey key)
	{
	get
	{
	return RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
	? Task.Factory.StartNew(() => new AsyncRegistryKey(Registry.LocalMachine))
Check warning on line 42 in src/JavaVersionSwitcher/Adapters/RegistryAdapter.cs GitHub Actions / build (windows-2022) `Property should not return created disposable (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP012.md)`
	: Task.Factory.StartNew<AsyncRegistryKey>(() => null);
	}
	}

	private static ITypeRegistrar BuildRegistrar()
	{
	var container = new Container();
Check warning on line 66 in src/JavaVersionSwitcher/Program.cs GitHub Actions / build (windows-2022) `Dispose created (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP001.md)`
	container.Options.ResolveUnregisteredConcreteTypes = true;
	container.Register<ILogger, Logger>(Lifestyle.Singleton);

	for (var index = 0; index < processesByName.Length; index++) {
	processIndexedName = index == 0 ? processName : processName + "#" + index;
	var processId = new PerformanceCounter("Process", "ID Process", processIndexedName);
Check warning on line 75 in src/JavaVersionSwitcher/Adapters/ShellAdapter.cs GitHub Actions / build (windows-2022) `Dispose created (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP001.md)`
	if ((int) processId.NextValue() == pid) {
	return processIndexedName;
	}
	"Accessing parent process is currently only available on windows.");
	}

	var parentId = new PerformanceCounter("Process", "Creating Process ID", indexedProcessName);
Check warning on line 91 in src/JavaVersionSwitcher/Adapters/ShellAdapter.cs GitHub Actions / build (windows-2022) `Dispose created (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP001.md)`
	return Process.GetProcessById((int) parentId.NextValue());
	}
	#pragma warning restore CA1416

	private async Task<Tuple<string, string>> GetVersion(string javaExePath)
	{
	var proc = new Process
Check warning on line 172 in src/JavaVersionSwitcher/Adapters/JavaInstallationsAdapter.cs GitHub Actions / build (windows-2022) `Dispose created (https://github.com/DotNetAnalyzers/IDisposableAnalyzers/blob/master/documentation/IDISP001.md)`
	{
	StartInfo = new ProcessStartInfo
	{