fix: cast time_config values to int before arithmetic#29
Open
wbryanta wants to merge 1 commit intonikmcfly:mainfrom
Open
fix: cast time_config values to int before arithmetic#29wbryanta wants to merge 1 commit intonikmcfly:mainfrom
wbryanta wants to merge 1 commit intonikmcfly:mainfrom
Conversation
LLMs may write time_config values as strings in JSON (e.g., "60" instead of 60). This causes a TypeError on simulation start. Fixes nikmcfly#28 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
LLMs may write
time_configvalues as strings in JSON (e.g.,"60"instead of60), causing aTypeErroron simulation start.Casts
total_simulation_hoursandminutes_per_roundtoint()before arithmetic.