Skip to content

Conversation

@kerwin612
Copy link

Add precondition detection: The installation of reviewdog in the container will fail if there is a network timeout. Therefore, if reviewdog does not exist, exit directly to avoid finding the problem after downloading checkstyle, which is a waste of time.

Downloading checkstyle theory also takes time. Before time-consuming operation (non-real-time response), output log feedback current process.

Here's the real problem I had

Running check
//I waited here for six minutes because of the network.
wget: error getting response: Resource temporarily unavailable
//In other words, it would take six minutes for me to know that there was a problem(reviewdog: not found) with the image build. The six-minute wait was completely useless.
/entrypoint.sh: line 18: reviewdog: not found
Error: Invalid or corrupt jarfile /checkstyle.jar

Add precondition detection: The installation of reviewdog in the container will fail if there is a network timeout. Therefore, if reviewdog does not exist, exit directly to avoid finding the problem after downloading checkstyle, which is a waste of time.

Downloading checkstyle theory also takes time. Before time-consuming operation (non-real-time response), output log feedback current process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant