Skip to content

Conversation

@james-freeburn
Copy link

Added a function that models a combined kilonova + afterglow SED. This supports use with the SimulateOpticalTransient class. Had to modify various kilonova functions to allow for 2D time arrays.

@nikhil-sarin
Copy link
Owner

Thanks @james-freeburn ! You don't need to change the kilonova functions though so I will ask you to revert that. What you want to do is generate the kilonova model with the 'spectra' output format. This returns a named tuple with spectra on a predefined lambda and time array.

@nikhil-sarin nikhil-sarin marked this pull request as draft November 21, 2025 12:17
@james-freeburn james-freeburn marked this pull request as ready for review December 2, 2025 03:04
@nikhil-sarin
Copy link
Owner

@james-freeburn thanks James this looks good. A small request. Could you add a default prior to the priors folder (you can see the syntax from other priors). This then automatically makes the function part of the CI tests.

I'm assuming you've tested this otherwise through the simulator and it works correctly?

@james-freeburn
Copy link
Author

I thought I tested it but apparently I did not - it works now and I've added a priors file. It will work now by just calling the default priors.

@nikhil-sarin
Copy link
Owner

nikhil-sarin commented Dec 18, 2025

The tests are failing, think av should be av_host, or failing because of something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants