fix: optimize transcription to only run when needed #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titaniumshovel
commented
Jul 11, 2025
titaniumshovel
commented
- Only call transcription API when save transcription is enabled OR there's an active markdown view
- Prevents unnecessary API calls and "Audio parsed successfully" notifications when only saving audio files
- Updated manifest ID and name to "whisper-fixed" for custom deployment
- Fixed esbuild config to handle missing OUTPUT_PATH environment variable
- Only call transcription API when save transcription is enabled OR there's an active markdown view - Prevents unnecessary API calls and "Audio parsed successfully" notifications when only saving audio files - Updated manifest ID and name to "whisper-fixed" for custom deployment - Fixed esbuild config to handle missing OUTPUT_PATH environment variable
Reverted the manifest ID and name back to "whisper" from "whisper-fixed". The name change was unnecessary for the transcription optimization fix and would interfere with proper plugin distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.