Remove 400 / shouldProtectDueToHIGH guard #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnzxy
requested review from
AndreasStokholm,
MikePlante1,
Sjoerd-Bo3,
bjornoleh,
marv-out and
t1dude
as code owners
|
Really happy to see this change likely being done. The current behavior has been a problem for teenagers with Trio, when they get into troubles and their parents cannot contact them to remind them that Trio stops automatic corrections at 400 mg/dL . Of the two options, I believe this new one is the least worst choice - as being really stuck high happens more often than what the previous behavior protection...! Thanks... |
MikePlante1
reviewed
Nov 16, 2025
| @@ -1,6 +1,7 @@ | |||
| oref0 branch: dev - git version: 37896e5 | |||
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the "400 guard" (via
TrioCustomOrefVariablesshouldProtectDueToHIGH) added in #622. That logic disabled SMBs and forced a neutral temp basal whenever the CGM reported flatlined HIGH values (400 mg/dL) [to avoid dosing on potentially invalid readings].Changes
shouldProtectDueToHIGHfromTrioCustomOrefVariables(model + decoding + constructor).glucoseIsHIGHhelper and all references.determine-basal.js(no forced neutral TBR, no SMB block).oref0_source_version.txtaccordingly.Rationale
The original guard was only meant as a temporary safety measure for suspicious HIGH readings. It’s no longer needed and diverges from upstream oref, so we’re removing it to restore standard oref behavior, to aid FCL users in underserved populations that semi-frequently run into situations where they get stuck on 400 mg/dL for a prolonged time period.