Skip to content

Conversation

@MikePlante1
Copy link
Contributor

There was a change (or bug?) in the iOS 26.1 Beta which broke the LoopStatusView from expanding to be viewable. Xcode says "Invalid sheet detent height: 0.0".

The hardcoded 90% does not look as good as when the View is working properly (like on the latest public release of iOS — 26.0.1) since it hides more of the screen and has an awkward gap below the Got It button, but since this PR just forces a 90% detent if the detent height is 0, users that aren't experience this problem won't be affected.

Once iOS 26.1 is officially released, if it's still falling back to the 90% version we should look into a more elegant solution.

dev 0.6.0.4 This PR
image 41C2C1F5-EBF2-4DE6-A7AD-C253ED7C7A75_1_101_o

@dnzxy
Copy link
Contributor

dnzxy commented Oct 22, 2025

I don’t think we need to provide any fixes or support, or introduce code changes for users running unreleased beta-type iOS versions. If this persists to be an issue in an upcoming official release of iOS, this becomes a different thing. Until then, I‘d not do any changes.

Copy link
Contributor

@t1dude t1dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's point affected users to this PR, but I agree that we should wait and see if this issue still exists when 26.1 is released.

@MikePlante1
Copy link
Contributor Author

I just installed the iOS 26.1 Release Candidate (23B82) and this is still an issue, so looks like we'll need that more elegant solution eventually, and this temporary patch-job if another solution is not found before 26.1 is officially released.

@MikePlante1
Copy link
Contributor Author

Just updated to the full release of 26.1 and confirmed this bug is still present with the latest dev 0.6.0.7

@MikePlante1 MikePlante1 linked an issue Nov 4, 2025 that may be closed by this pull request
@MikePlante1
Copy link
Contributor Author

Updated it a bit. Now,

  • If it can set a calculated size it'll set it to that (< iOS 26.1)
  • If it can't, it sets 0.9 which seems to be fine for most cases, but might cut off the button for SEs in certain cases
  • Either way, you can now swipe to make it full screen.
detent.mov

Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this about as good as it will get for now.

I have been trying various things to enforce a rerendering of the sheet once content detent height can properly be calculated by the GeometricReader but it seems like it’s not doing what it should on iOS 18.x and iOS 26 (26.0.1 nor 26.1).

Let’s get this in for now :)

pepijnjoost added a commit to pepijnjoost/Trio that referenced this pull request Nov 7, 2025
@dnzxy dnzxy changed the title Fallback Plan for LoopStatusView Detent Fix iOS 26.1 LoopStatusView Detent Issue Nov 7, 2025
@pepijnjoost
Copy link

Is working just like @MikePlante1 posted!

@MikePlante1 MikePlante1 merged commit 0aceed0 into nightscout:dev Nov 8, 2025
3 checks passed
@MikePlante1 MikePlante1 deleted the detent branch November 8, 2025 22:33
@g5WS
Copy link

g5WS commented Nov 9, 2025

Big heaps of thanks, @MikePlante1 !

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuzzy screen and displaced loop status popup

5 participants