Add recommended bolus and pump bolus increment to Nightscout devicestatus #793
Conversation
bjorkert
requested review from
AndreasStokholm,
MikePlante1,
Sjoerd-Bo3,
bjornoleh,
dnzxy,
marv-out and
t1dude
as code owners
|
|
I made some updates to this PR, see below:
|
|
My son is using this branch, it has been running without issues. Currently developing the LoopFollow side of this. |
|
Doing some refactoring and re-implementing upload triggering from APSManager to catch situations where the upload based on data fails, but in a way that prevent duplicate uploads. Changing this PR to a draft while working/testing. |
… throttle) + APS triggers uploads
|
Pulled the Nightscout subscriber logic into BaseNightscoutManager+Subscribers.swift and added lane-based “kick” pipelines (2s throttle) to avoid double uploads. APSManager now requests uploads via requestNightscoutUpload (carbs/pumpHistory/overrides/tempTargets). I'll resume testing and will open up this for review again if/when I am happy with the tests. |
dnzxy
left a comment
dnzxy
left a comment
There was a problem hiding this comment.
I'll approve this based on in-vivo testing on my end and in-vivo testing with LFxTrio on @bjorkert 's end with his son's setup.
Jonas and I have discussed this PR extensively via DM over the last ~2 weeks.
Are we okay with the naming and changes here? Functionality-wise it's okay, but it is a bigger change, so asking you folks, too, @marv-out @kingst .
kingst
left a comment
kingst
left a comment
There was a problem hiding this comment.
Overall this LGTM. I didn't test it, my review is just from reading the code. I have one optional suggestion and one question but in general this PR is ready to go.
| extension BaseNightscoutManager { | ||
| /// Call once from init. Hooks up: | ||
| /// 1) external upload requests (NotificationCenter) | ||
| /// 2) Core Data change triggers → kicks per lane |
There was a problem hiding this comment.
[minor / optional] I haven't seen the phrases kick or lane, is this a standard nomenclature for Combine workflows? I think I understand what it means, but maybe lanes are classes / objects and kicks are sends? I'm not 100% sure so this comment is optional
| private let queue = DispatchQueue(label: "BaseNightscoutManager.queue", qos: .background) | ||
| private var coreDataPublisher: AnyPublisher<Set<NSManagedObjectID>, Never>? | ||
| private var subscriptions = Set<AnyCancellable>() | ||
| let queue = DispatchQueue(label: "BaseNightscoutManager.queue", qos: .utility) |
There was a problem hiding this comment.
Why did you change the qos, was there priority inversion?
3 participants
This PR adds two fields to the Nightscout upload so clients like LoopFollow can display a correction recommendation and respect the pump’s bolus step:
• openaps.recommendedBolus — the treatment view equivalent recommended correction bolus, for no new carbs.
• pump.bolusIncrement — the smallest supported bolus volume from the active pump.