Fix spaces around module selectors in generics - #2660
Merged
Conversation
Add `::` to the list of operators allowed inside generic angle brackets in the tokenizer, preventing `<` from being misidentified as an operator when a module selector appears in generic type parameters. Co-authored-by: calda <1811727+calda@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unexpected spaces around module selectors
Fix spaces around module selectors in generics
Aug 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2660 +/- ##
========================================
Coverage 95.45% 95.46%
========================================
Files 178 178
Lines 27137 27137
========================================
+ Hits 25904 25905 +1
+ Misses 1233 1232 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
calda
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a module selector (
::) appears inside generic angle brackets, the tokenizer didn't recognize::as a valid operator within a generic scope. This caused<to be reclassified fromstartOfScopetooperator, andspaceAroundOperatorsthen inserted spaces around it:"::"to the whitelist of operators allowed inside<...>generic scopes inTokenizer.swift