Fix disable:next handling in multiline strings - #2646
Open
EhsanAzish80 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2646 +/- ##
========================================
Coverage 95.44% 95.45%
========================================
Files 177 177
Lines 27073 27080 +7
========================================
+ Hits 25841 25848 +7
Misses 1232 1232 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2645.
disable:nextwas consumed by the first physical line break inside a multiline string, allowing disabled rules such aswrapto run on the remaining string contents.This change evaluates rule enablement within multiline strings from the opening delimiter, including content inside string interpolation scopes. The directive therefore applies to the entire multiline string while formatting resumes normally afterward.
Added focused regression coverage that reproduces the unwanted wrapping and verifies formatting resumes after the string.
Testing: