reloadData + valueForKeyPath#376
Open
Julioacarrettoni wants to merge 2 commits intonicklockwood:masterfrom
Open
reloadData + valueForKeyPath#376Julioacarrettoni wants to merge 2 commits intonicklockwood:masterfrom
Julioacarrettoni wants to merge 2 commits intonicklockwood:masterfrom
Conversation
When trying the “BasicExample” the app crashes on any of the “multiple choice” fields, for example on “Gender”. This little change fixes this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 things:
When assigning a new form to a formController or reassigning the existing one the content doesn't refresh, so a "reloadData" was added just after the form is assigned.
When dealing with "multiple choice" fields the app was crashing due to the fact that "valueForKey" was returning the "value" instead of the "field" object inside FXFormOption.
Using "valueForKeyPath" and changing the current overriding of "valueForKey" to "valueForUndefinedKey" seems to fix this issue.
To reproduce the issue just run the "BasicExample" with the current form, go to Register and select Gender.