Keep SDK template manifests cargo-readable - #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{ package_name }}package names in templateCargo.tomlfiles with valid default package names.patina-sdkfrom this repository.Why / Design
Cargo scans
Cargo.tomlfiles in git dependencies before any cargo-generate rendering happens. The template manifests used raw Liquid placeholders in[package].name, which made Cargo report invalid package names whenever another repo depended onpatina-sdkby git rev.This keeps the template manifests syntactically valid as checked-in TOML. It does not change SDK manifest parsing or runtime behavior.
Changes
sdk/template/Cargo.toml: valid default package name.sdk/template/checks/diagnostics/Cargo.toml: valid default diagnostics package name.sdk/template-legacy/Cargo.toml: valid default package name.Validation
Local:
cargo metadata --no-deps --format-version 1cargo test -p patina-sdk --no-default-features --features manifestcargo test --test template_end_to_end -- --nocapture— passed; cargo-generate e2e skipped becausecargo generateis not installed locally.GitHub Actions:
Require Linked Issue— passedLint— passedTest— passedRelease— passedRetrieval Benchmark— skippedCompatibility / Operations
Follow-ups