Route Mother child manifests through SDK contract - #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patina_sdk::manifest::ChildManifestfor canonical identity, ingress, contract, andneeds.toysfields.patina child installdefault artifact resolution throughpatina_sdk::manifest::ChildPackage, removing local target-directory WASM inference.Why / Design
child.tomlcontract rules; Mother should project SDK facts into its richer runtime model instead of duplicating those rules locally.capabilities,needs.scopes,provides,schemas, metrics, connections) remain parsed from raw TOML because they are runtime policy/config extensions not yet owned by the SDK model.[child.artifact].wasmpath unless the operator explicitly passes--wasm; implicit search through target directories is removed.Changes
src/child/internal/mod.rspatina_sdk::manifest::ChildManifestfor canonical manifest fieldssrc/main_dispatch/child.rspatina_sdk::manifest::ChildPackagefor default package artifact resolutionchildren/*/child.tomlchild.versionfields to in-repo child manifestsmother/src/toys/git.rsGIT_DIR,GIT_WORK_TREE,GIT_INDEX_FILE,GIT_PREFIX) before running git in a selected repoValidation
cargo test child::internal::tests --libcargo test commands::mother::loader::tests --libcargo test registry::tests -p mothercargo test child_install_testscargo test --test mother_typed_fixture_conformancecargo test --test child_init_typed_defaultcargo test commands::slate::tests::slate_project_preopen --libcargo test commands::mother::daemon::tests::installed_children_use_manifest_name_not_wasm_stem --libcargo test toys::git::tests -p mothercargo check -qCompatibility / Operations
child.name,child.version, andchild.kindto load under Mother runtime parsing.--wasmmust declare[child.artifact].wasminchild.tomland the file must exist inside the package.--wasmremains available for operator-provided artifact overrides.Follow-ups
patina-sdkmanifest support when ready so external consumers do not need to rely on source-tree path/git integration.