Repository navigation
Skip error 404 logging - #698
Closed
colinrotherham wants to merge 4 commits into
Closed
colinrotherham wants to merge 4 commits into
colinrotherham wants to merge 4 commits into
Conversation
Member
|
@colinrotherham sorry for being slow to this. Happy for this to be merged. Would you mind checking that we’ve also got this covered in https://github.com/nhsuk/nhsuk-prototype-kit-package/tree/main/lib/express-middleware ? There we have 2 separate middleware functions:
Only 500 errors should show an error in the console (seems to work on the test app). |
frankieroberto
approved these changes
Nov 26, 2025
Member
|
Closing this, as it’ll be done upstream at https://github.com/nhsuk/nhsuk-prototype-kit-package/blob/main/lib/middleware/render-page-not-found.js instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR skips 404 logging to reduce noise
Closes #697
Checklist