Skip to content

Skip error 404 logging - #698

Closed
colinrotherham wants to merge 4 commits into
nhsuk:mainfrom
colinrotherham:404-logging
Closed

colinrotherham wants to merge 4 commits into
nhsuk:mainfrom
colinrotherham:404-logging

Conversation

@colinrotherham

Copy link
Copy Markdown
Contributor

Description

This PR skips 404 logging to reduce noise

Closes #697

Checklist

  • Tested against our testing policy (Resolution, Browser & Accessibility)
  • CHANGELOG entry

@frankieroberto

Copy link
Copy Markdown
Member

@colinrotherham sorry for being slow to this. Happy for this to be merged.

Would you mind checking that we’ve also got this covered in https://github.com/nhsuk/nhsuk-prototype-kit-package/tree/main/lib/express-middleware ? There we have 2 separate middleware functions:

Only 500 errors should show an error in the console (seems to work on the test app).

@frankieroberto

Copy link
Copy Markdown
Member

Closing this, as it’ll be done upstream at https://github.com/nhsuk/nhsuk-prototype-kit-package/blob/main/lib/middleware/render-page-not-found.js instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lots of 404 errors for first time users

2 participants