Skip to content

survey: Override ICU to have static libs #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −0
Draft

survey: Override ICU to have static libs #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions survey/default.nix
View file
Original file line number Diff line number Diff line change
@@ -661,6 +661,18 @@ let
SDL2_image = previous.SDL2_image.overrideAttrs (old: { dontDisableStatic = true; });
SDL2_mixer = previous.SDL2_mixer.overrideAttrs (old: { dontDisableStatic = true; });

# For icu, `dontDisableStatic` is not enough. We need explicit `--enable-static`.
# See https://github.com/unicode-org/icu/blob/0735ea8c6f6a0efa258db1f047edc63a43c6aafa/icu4c/source/configure.ac#L289-L299
# Also potentially concerning: http://userguide.icu-project.org/packaging
# > Users of your ICU must compile with -DU_STATIC_IMPLEMENTATION.
# TODO: Override ALL icu derivations, not just icu64.
icu64 = previous.icu64.overrideAttrs (old: {
dontDisableStatic = true;
configureFlags = (old.configureFlags or []) ++ [
"--enable-static"
];
});

libjpeg = previous.libjpeg.override (old: { enableStatic = true; });
libjpeg_turbo = previous.libjpeg_turbo.override (old: { enableStatic = true; });