Skip to content

Conversation

@timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Dec 8, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The main build still fails.

What is the new behavior?

  • Split all type tests in effects because these are causing timeouts. Also reword the test names (remove the "should" form). This doesn't fix all issues, therefor the timeout is increased for all type tests.
  • Mock console.error, this is causing noise in the output.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 4eb104c
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/69386712db49130008c0dfa8

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 4eb104c
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/693867124d48c600087ad9ea
😎 Deploy Preview https://deploy-preview-5044--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@timdeschryver timdeschryver force-pushed the main-ci-v2 branch 3 times, most recently from e0d3711 to d2e86b2 Compare December 9, 2025 10:17
@timdeschryver
Copy link
Member Author

timdeschryver commented Dec 9, 2025

The last issue is the failing snapshot tests.
Funny enough, these are green when running all tests, but are red when running the affected test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants