Skip to content

Conversation

@timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The merges of the recent Vitest changes result in a failing build, due to timeouts and snapshots(?).

What is the new behavior?

This PR does a few things:

  • add parallel=3 to address the MaxListenersExceededWarning warning, which happens because of the NX parallelization. I suppose this also free's up some memory for the tasks.
  • add --skip-nx-cache for the build step, we recently already added this for the ci workflow
  • remove expectSnippet().toSucceed() calls when we infer code. This will fix the time-outs, toInfer already verifies the compilation is succesfull.
  • Update snapshots (no idea why these suddenly fail)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Dec 7, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 38227d2
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6935a0b0051ba100081a09db

@netlify
Copy link

netlify bot commented Dec 7, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 38227d2
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6935a0b05c20c30008b44f1e
😎 Deploy Preview https://deploy-preview-5043--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@brandonroberts brandonroberts merged commit adf4a85 into main Dec 8, 2025
14 checks passed
@brandonroberts brandonroberts deleted the main-ci branch December 8, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants