-
Notifications
You must be signed in to change notification settings - Fork 101
fix: adding rhel-9 compiler install and sec updates manual upload instructions #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current line 102 includes ### RHEL 8.1 or later
. (This PR adds a section: ### RHEL 9 or later
)
Can we replace with ### RHEL 8.x
Also, I'm unable to check the commands -- I trace this to an error in the NAP WAF docs, which still point to RHEL 7 (CentOS 7, actually)

Hi @mjang, |
As shown from the second .repo file in the link, we point to CentOS 7. (I've tried a couple of variations, such as
|
So I try various commands and end up with errors like:
|
Hi @mjang, Could you please clarify how your comments relate to this PR? It would be helpful if you could point out the exact location I should look into. Also, could you explain what the second .repo file refers to? Where in this PR are we referencing CentOS 7? I couldn’t find any mention of baseurl=https://pkgs.nginx.com/app-protect-x-oss/centos/7/$basearch/. Could you point me to where it’s being used? |
Also, how is this comment related to this PR? Could you please provide some details? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar and style lgtm
Proposed changes
Adding the instructions for
Testing
I have performed local testing.
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩