-
Notifications
You must be signed in to change notification settings - Fork 100
feat: Add sni related config options to jwt policy #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nic-release-5.2
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM: if these are intended for an upcoming release, we could probably set-up the new release branch so that can be the target instead of main.
Otherwise, I'm somewhat inclined to keep this in draft just in case someone merges prematurely.
Excellent suggestion, thank you. I need to figure out how to not forget about this draft PR though 🤔 |
Proposed changes
Adds two new configuration options to the NIC / jwt policy options:
sniEnabled
andsniName
.Functionality PR for the underlying code is nginx/kubernetes-ingress#7993.
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩