Parameterize nginx-proxy and docker-gen container labels #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enable users to be able to change the default label acme-companion uses to lookup for nginx and docker-gen containers, allowing more personalization to further uses of acme-companion.
As an example, nginx-proxy/nginx-proxy project now defines it's nginx-proxy label as
com.github.nginx-proxy.nginx-proxy.nginx, instead of adding an exception to the case to handle current nginx-proxy labelcom.github.nginx-proxy.nginxas a secondary legacy label, it provides a way to pass custom container labels through the parameterization of the current container labels.