Disable PHP_DISPLAY_ERRORS by default and add documentation#76
Open
RisingOpsNinja wants to merge 2 commits intonfrastack:mainfrom
Open
Disable PHP_DISPLAY_ERRORS by default and add documentation#76RisingOpsNinja wants to merge 2 commits intonfrastack:mainfrom
RisingOpsNinja wants to merge 2 commits intonfrastack:mainfrom
Conversation
Don't show PHP errors to users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, thank you for your work on the Docker images.
I suggest that it would be better to disable PHP setting display_errors by default. For test environments, the setting can be very helpful, but for production environments it could lead to exposes sensitive information.
The environment variable
PHP_DISPLAY_ERRORSto control it, is also not documented, so it is easily overlooked.Best regards