Skip to content

Conversation

@edmundmiller
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

 Test running successfully - The pipeline launched with the new workflow outputs structure:
  - publish: block in entry workflow ✅
  - output {} block with dynamic paths ✅
  - workflow.output.mode = 'copy' in config ✅

  What this means:
  - The new workflow outputs feature is additive - it publishes outputs through the new system
  - The old publishDir system is still active in the configs
  - Both systems will publish outputs (some duplication expected until publishDir is removed)
Workflow outputs infrastructure added:
  - publish: block in entry workflow (main.nf)
  - output {} block with dynamic paths
  - workflow.output.mode = 'copy' in nextflow.config
Channel emission chain established:
  - fastq_preprocess_gatk → SAREK workflow → NFCORE_SAREK entry workflow
- Add markduplicates_metrics output channel
- Add strelka genome VCF/TBI output channels (separate from variant VCF)
- Thread all new channels through workflow hierarchy
- Update nf-test snapshots with new outputs
- Add MD QC channel propagation through workflow hierarchy
- Fix strelka genome VCF TBI output in bam_variant_calling_single_strelka
- Fix mosdepth stub file naming to include .mosdepth. infix
- Update test snapshot with consistent naming
@edmundmiller edmundmiller self-assigned this Dec 3, 2025
@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@junjundigal57-alt

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants